CORS-3419,OCPBUGS-30941: Include baremetal IPI in openshift-installer#8161
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@zaneb: This pull request references CORS-3419 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@zaneb: This pull request references CORS-3419 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
zaneb
force-pushed
the
baremetal-in-all-builds
branch
2 times, most recently
from
c68910d to
ccc571d
Compare
|
/retitle CORS-3419,OCPBUGS-30941: Include baremetal IPI in openshift-installer |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/severity-low
|
@zaneb: This pull request references CORS-3419 which is a valid jira issue. This pull request references Jira Issue OCPBUGS-30941, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@zaneb: This pull request references CORS-3419 which is a valid jira issue. This pull request references Jira Issue OCPBUGS-30941, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
For builds with baremetal support (until now only the openshift-baremetal-installer), the agent installer was attempting to validate the bootstrap provisioning network using libvirt. This is not required because the agent installer does not make use of a bootstrap VM.
Change the plugin point for the unit tests from the validation function itself to the function that looks up the interfaces in libvirt. This allows us to unit test the validation function.
Now that we do not dynamically link to libvirt, there is no need to restrict baremetal IPI to the openshift-baremetal-installer binary and it can be included in all builds of the installer.
zaneb
force-pushed
the
baremetal-in-all-builds
branch
from
ccc571d to
78a8275
Compare
|
/retest |
|
/approve |
|
@zaneb should https://github.com/openshift/installer/blob/master/images/baremetal/Dockerfile.ci be modified as part of these changes? See #8240 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
This change shouldn't affect openshift-baremetal-install at all, but there will be changes to that upcoming. |
|
It would be good if we could update one of the metal jobs to use the |
It seems /lgtm |
|
/retest-required |
|
@zaneb: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold Revision 78a8275 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest-required |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@zaneb: Jira Issue OCPBUGS-30941: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-30941 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
With openshift/installer#8161, the baremetal installer is now part of the regular installer which is now statically linked. Using the static binary has the advantage of working on both CS8 and CS9 VMs and is a necessary step for moving the Installer images to a RHEL9 base.
With openshift/installer#8161, the baremetal installer is now part of the regular installer which is now statically linked. Using the static binary has the advantage of working on both CS8 and CS9 VMs and is a necessary step for moving the Installer images to a RHEL9 base.
With openshift/installer#8161, the baremetal installer is now part of the regular installer which is now statically linked. Using the static binary has the advantage of working on both CS8 and CS9 VMs and is a necessary step for moving the Installer images to a RHEL9 base.
With openshift/installer#8161, the baremetal installer is now part of the regular installer which is now statically linked. Using the static binary has the advantage of working on both CS8 and CS9 VMs and is a necessary step for moving the Installer images to a RHEL9 base.
With openshift/installer#8161, the baremetal installer is now part of the regular installer which is now statically linked. Using the static binary has the advantage of working on both CS8 and CS9 VMs and is a necessary step for moving the Installer images to a RHEL9 base.
With openshift/installer#8161, the baremetal installer is now part of the regular installer which is now statically linked. Using the static binary has the advantage of working on both CS8 and CS9 VMs and is a necessary step for moving the Installer images to a RHEL9 base.
With openshift/installer#8161, the baremetal installer is now part of the regular installer which is now statically linked. Using the static binary has the advantage of working on both CS8 and CS9 VMs and is a necessary step for moving the Installer images to a RHEL9 base.
With openshift/installer#8161, the baremetal installer is now part of the regular installer which is now statically linked. Using the static binary has the advantage of working on both CS8 and CS9 VMs and is a necessary step for moving the Installer images to a RHEL9 base.
4 participants
Now that we do not dynamically link to libvirt, there is no need to restrict baremetal IPI to the openshift-baremetal-installer binary and it can be included in all builds of the installer.