CORS-4299,CORS-4300: Allow N4A Instance Types in the installer #10211
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@barbacbd: This pull request references CORS-4299 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. This pull request references CORS-4300 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
barbacbd
force-pushed
the
installer-n4a-instances
branch
from
9bd3a1a to
e2cd3ea
Compare
|
/cc @jianli-wei |
tthvo
left a comment
tthvo
left a comment
There was a problem hiding this comment.
Looks good to me!@ I have a few questions :D
barbacbd
force-pushed
the
installer-n4a-instances
branch
from
e2cd3ea to
83fd10f
Compare
Update the GCP provider reference so that N4A instances can be validated. Note: govmomi was set to v0.51.0 because the MAPI updates were causing an automatic update to v0.52.0 resulting in build issues that have no current solution.
barbacbd
force-pushed
the
installer-n4a-instances
branch
from
83fd10f to
08f6873
Compare
pkg/types/gcp/machinepools.go: Include the n4a instance type in the map as well as the (current) supported disk types: - hyperdisk-balanced pkg/asset/installconfig/gcp/validation.go: Include n4a in the types of arm instance families.
barbacbd
force-pushed
the
installer-n4a-instances
branch
from
08f6873 to
f7eb72b
Compare
|
A local installation of an arm64 cluster completes successfully and shows the instances can be launched with # registry.ci.openshift.org/ocp-arm64/release-arm64:4.22.0-0.nightly-arm64-2026-01-19-132506
$ yq .controlPlane.platform.gcp install-config.yaml
osDisk:
diskSizeGB: 200
diskType: hyperdisk-balanced
type: n4a-standard-16
$ yq .compute[0].platform.gcp install-config.yaml
osDisk:
diskSizeGB: 200
diskType: hyperdisk-balanced
type: n4a-standard-16
$ gcloud compute instances list --format="table(name,machineType.basename(),zone)"
NAME MACHINE_TYPE ZONE
thvo-gcp-n4a-mcvg9-bootstrap n4a-standard-16 us-east1-b
thvo-gcp-n4a-mcvg9-master-0 n4a-standard-16 us-east1-b
thvo-gcp-n4a-mcvg9-master-2 n4a-standard-16 us-east1-b
thvo-gcp-n4a-mcvg9-worker-b-nwqzw n4a-standard-16 us-east1-b
thvo-gcp-n4a-mcvg9-worker-b-t4g8d n4a-standard-16 us-east1-b
thvo-gcp-n4a-mcvg9-master-1 n4a-standard-16 us-east1-c
thvo-gcp-n4a-mcvg9-worker-c-csclf n4a-standard-16 us-east1-c |
|
/approve |
|
/verified by @tthvo |
openshift-ci-robot
added
the
verified
|
@patrickdillon: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
/test e2e-aws-ovn |
|
@barbacbd: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
CORS-4299: Update the vendor references to get the MAPI GCP Provider changes. This will allow the validation of N4A instance types as arm instances rather than defaulting to x86.
CORS-4300: Update installer to allow n4a instances
pkg/types/gcp/machinepools.go:
pkg/asset/installconfig/gcp/validation.go: