-
Notifications
You must be signed in to change notification settings - Fork 1.5k
CORS-4055: migrate IAM API calls to AWS SDK v2 #10245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The commit is an incremental step to migrate AWS API calls to AWS SDK v2. This focuses on IAM clients in the pkg/asset and dependent pkg(s).
|
@tthvo: This pull request references CORS-4055 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aws-ovn-custom-iam-profile |
|
/label platform/aws We need to wait for #9982 to merge first. Then, we'll need to |
|
/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-multi-nightly-aws-ipi-byo-iam-profile-mini-perm-arm-f7 |
|
@yunjiang29: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/119a12e0-f844-11f0-8a3b-c8d3bacf713a-0 |
barbacbd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: barbacbd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/payload-job periodic-ci-openshift-openshift-tests-private-release-4.22-multi-nightly-aws-ipi-byo-iam-profile-mini-perm-arm-f7 |
|
@yunjiang29: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8e446d60-fb2b-11f0-869f-357234b3f4bc-0 |
|
/lgtm |
|
/retest |
|
@tthvo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/verified by @yunjiang29 |
|
@yunjiang29: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
The PR is an incremental step to migrate AWS API calls to AWS SDK v2. This focuses on IAM clients in the
pkg/assetand dependent pkg(s). To check if any AWS SDK v1, we can run:Notes: References in the destroy code will be migrated to AWS SDK v2 in #9982.