-
Notifications
You must be signed in to change notification settings - Fork 1.5k
AGENT-1431: Backport feature NoRegistryClusterInstall to 4.21 #10250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.21
Are you sure you want to change the base?
AGENT-1431: Backport feature NoRegistryClusterInstall to 4.21 #10250
Conversation
The agent-ui service was previously updated to 'Type=notify' to improve startup ordering and reliability. However, the lack of container monitor '--sdnotify=conmon' flag, resulted in UI URL to be not displayed on the TUI. Without this flag, agent-ui systemd waits for a readiness signal which never comes and the service remains in 'activating' state. This causes the TUI availability check to fail, making the user only see "Waiting for services" instead of UI URL ( even though the UI is already avaialble via the usual URL) This commit adds the missing flag, ensuring the notification handshake between the container running UI and the agent-ui systemd completes successfully and unblocking the TUI. This commit also fixes the stale dependency in agent-register-infraenv related to agent-ui systemd naming.
|
@pawanpinjarkar: This pull request references AGENT-1431 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@pawanpinjarkar: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is a manual cherry-pick of below stories:
https://issues.redhat.com/browse/AGENT-1425 Local assisted UI url not shown in the terminal console PR #10237
https://issues.redhat.com/browse/AGENT-1309: Modify NoRegistryClusterInstall storage requirements PR #10176