-
Notifications
You must be signed in to change notification settings - Fork 1.5k
CORS-4055: migrate default region check to AWS SDK v2 #10267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The commit is an incremental step to migrate AWS API calls to AWS SDK v2. This only focuses on logics to get the default region from loaded config for the survey.
|
@tthvo: This pull request references CORS-4055 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/cc @yunjiang29 |
|
I did a quick local test and it worked as expected 👇 Minimal run - Default region should be from the AWS profile ./openshift-install create install-config --dir=.
? SSH Public Key <path>
? Platform aws
INFO Credentials loaded from the AWS config using "SharedConfigCredentials: <path>" provider
? Region [Use arrows to move, type to filter, ? for more help]
me-south-1 (Middle East (Bahrain))
mx-central-1 (Mexico (Central))
sa-east-1 (South America (São Paulo))
> us-east-1 (US East (N. Virginia))
us-east-2 (US East (Ohio))
us-west-1 (US West (N. California))
us-west-2 (US West (Oregon))Explicit region - Default region should be the specified region$ AWS_REGION=us-west-1 ./openshift-install create install-config --dir=.
? SSH Public Key <path>
? Platform aws
INFO Credentials loaded from the AWS config using "SharedConfigCredentials: <path>" provider
? Region [Use arrows to move, type to filter, ? for more help]
me-south-1 (Middle East (Bahrain))
mx-central-1 (Mexico (Central))
sa-east-1 (South America (São Paulo))
us-east-1 (US East (N. Virginia))
us-east-2 (US East (Ohio))
> us-west-1 (US West (N. California))
us-west-2 (US West (Oregon))Explicit invalid region - Default region should fall back to
|
|
/retest |
|
@tthvo: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@liweinan can you do a pre-merge test against this PR? |
The PR is an incremental step to migrate AWS API calls to AWS SDK v2. This only focuses on logics to get the default region from loaded config for the survey.
Note: This code path is applicable for the survey that asks the users for the install region.