Skip to content

Conversation

@tthvo
Copy link
Member

@tthvo tthvo commented Jan 28, 2026

The PR is an incremental step to migrate AWS API calls to AWS SDK v2. This only focuses on logics to get the default region from loaded config for the survey.

Note: This code path is applicable for the survey that asks the users for the install region.

The commit is an incremental step to migrate AWS API calls
to AWS SDK v2. This only focuses on logics to get the default region
from loaded config for the survey.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 28, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 28, 2026

@tthvo: This pull request references CORS-4055 which is a valid jira issue.

Details

In response to this:

The PR is an incremental step to migrate AWS API calls to AWS SDK v2. This only focuses on logics to get the default region from loaded config for the survey.

Note: This code path is applicable for the survey that asks the users for the install region.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign barbacbd for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tthvo
Copy link
Member Author

tthvo commented Jan 28, 2026

/cc @yunjiang29
/label platform/aws

@tthvo
Copy link
Member Author

tthvo commented Jan 28, 2026

I did a quick local test and it worked as expected 👇

Minimal run - Default region should be from the AWS profile

 ./openshift-install create install-config --dir=.
? SSH Public Key <path>
? Platform aws
INFO Credentials loaded from the AWS config using "SharedConfigCredentials: <path>" provider 
? Region  [Use arrows to move, type to filter, ? for more help]
  me-south-1 (Middle East (Bahrain))
  mx-central-1 (Mexico (Central))
  sa-east-1 (South America (São Paulo))
> us-east-1 (US East (N. Virginia))
  us-east-2 (US East (Ohio))
  us-west-1 (US West (N. California))
  us-west-2 (US West (Oregon))

Explicit region - Default region should be the specified region

$ AWS_REGION=us-west-1 ./openshift-install create install-config --dir=.
? SSH Public Key <path>
? Platform aws
INFO Credentials loaded from the AWS config using "SharedConfigCredentials: <path>" provider 
? Region  [Use arrows to move, type to filter, ? for more help]
  me-south-1 (Middle East (Bahrain))
  mx-central-1 (Mexico (Central))
  sa-east-1 (South America (São Paulo))
  us-east-1 (US East (N. Virginia))
  us-east-2 (US East (Ohio))
> us-west-1 (US West (N. California))
  us-west-2 (US West (Oregon))

Explicit invalid region - Default region should fall back to us-east-1

AWS_REGION=us-west-13 ./openshift-install create install-config --dir=.
? SSH Public Key <path>
? Platform aws
INFO Credentials loaded from the AWS config using "SharedConfigCredentials: <path>" provider 
WARNING Unrecognized AWS region "us-west-13", defaulting to us-east-1 
? Region  [Use arrows to move, type to filter, ? for more help]
  me-south-1 (Middle East (Bahrain))
  mx-central-1 (Mexico (Central))
  sa-east-1 (South America (São Paulo))
> us-east-1 (US East (N. Virginia))
  us-east-2 (US East (Ohio))
  us-west-1 (US West (N. California))
  us-west-2 (US West (Oregon))

@tthvo
Copy link
Member Author

tthvo commented Jan 28, 2026

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2026

@tthvo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-heterogeneous 0ef07df link false /test e2e-aws-ovn-heterogeneous

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yunjiang29
Copy link
Contributor

@liweinan can you do a pre-merge test against this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. platform/aws

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants