Skip to content

OCPBUGS-75250: Use correct Project ID with GCP Shared VPC #10297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sadasu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-75250: Use correct Project ID with GCP Shared VPC #10297

sadasu wants to merge 1 commit into from

Conversation

@sadasu
Copy link
Contributor

@sadasu sadasu commented Feb 11, 2026

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 11, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 11, 2026

@sadasu: This pull request references Jira Issue OCPBUGS-75250, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianli-wei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

patrickdillon
patrickdillon reviewed Feb 11, 2026
View reviewed changes
pkg/infrastructure/gcp/clusterapi/clusterapi.go Outdated
}

apiIntIPAddress, err := getInternalLBAddress(ctx, in.InstallConfig.Config.GCP.ProjectID, in.InstallConfig.Config.GCP.Region, getAPIAddressName(in.InfraID), in.InstallConfig.Config.GCP.Endpoint)
apiIntIPAddress, err := getInternalLBAddress(ctx, networkProjectID, in.InstallConfig.Config.GCP.Region, getAPIAddressName(in.InfraID), in.InstallConfig.Config.GCP.Endpoint)
Copy link
Contributor

@patrickdillon patrickdillon Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I told you the wrong fix. This is actually ok as the LB is in the service project. The issue is here where we are using the host project instead of the service project.

Copy link
Contributor Author

@sadasu sadasu Feb 11, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. We realized we needed a different fairly quickly and thanks for helping us get to the right fix.

@sadasu
Use GCP service project when getting Load Balancer IPs
47e3ad9 
Switched to getting GCP Load Balancer IP addresses from the service
project "GCP.ProjectID" in all cases, even when Shared VPC (XPN) is
configured.

This fix provides the correct project to use for getting the Load
Balancer IP address when UserProvisionedDNS is enabled, and the
ignition files are updated with the Load Balancer IP.
@sadasu sadasu force-pushed the sadasu-OCPBUGS-75250 branch from 8675665 to 47e3ad9 Compare February 11, 2026 18:33
@patrickdillon
Copy link
Contributor

patrickdillon commented Feb 11, 2026

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 11, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2026
@sadasu
Copy link
Contributor Author

sadasu commented Feb 11, 2026

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 12, 2026

@sadasu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-custom-dns 47e3ad9 link false /test e2e-gcp-custom-dns

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon patrickdillon left review comments

@jianli-wei jianli-wei Awaiting requested review from jianli-wei

@barbacbd barbacbd Awaiting requested review from barbacbd

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sadasu @openshift-ci-robot @patrickdillon