SPLAT-2622: Bump govmomi to v0.53.0#10431
Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom Mar 26, 2026
Merged
SPLAT-2622: Bump govmomi to v0.53.0#10431openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
Conversation
Removes the replace directive that was pinning govmomi to v0.51.0, allowing the project to use the latest v0.53.0 release. Also updates transitive dependencies
In govmomi v0.53.0, the CnsQueryFilter struct's GetCnsQueryFilter() method uses a pointer receiver, so it must be passed by pointer to satisfy the BaseCnsQueryFilter interface when calling QueryVolume().
openshift-ci-robot
added
the
jira/valid-reference
Contributor
|
@AnnaZivkovic: This pull request references SPLAT-2622 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (194)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughUpdated several Go dependency versions in two Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.11.3)Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions Comment |
Contributor
|
/lgtm |
Contributor
|
/assign @tthvo |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Contributor
|
/retest-required |
Member
|
/verified by CI |
openshift-ci-robot
added
the
verified
Contributor
|
@tthvo: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
verified
Member
|
@AnnaZivkovic I noticed joe's comment that we should not update capv provider deps. Is there any new reason that we do it now? cc @jcpowermac |
AnnaZivkovic
force-pushed
the
bump-govmomi
branch
from
40eff99 to
b99e8ec
Compare
Contributor
|
/lgtm |
Contributor
Author
That was a mistake on my part. I dropped the commits |
Contributor
Its tied to capv, I would suspect there are quite a few changes required there that would need to be done in order to bump oops wrong version of capv, this one: |
Member
|
/test gofmt |
Member
Ahh ack. Just waiting on CI results before adding |
Member
|
/verified by CI |
openshift-ci-robot
added
the
verified
Contributor
|
@tthvo: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
@AnnaZivkovic: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
github.com/vmware/govmomidependency from v0.51.0 to v0.53.0 and fixes a breaking API change in the CNS (Cloud Native Storage) client.Dependency Updates
replacedirective that was pinning govmomi to v0.51.0golang.org/x/crypto: v0.46.0 → v0.47.0golang.org/x/sys: v0.39.0 → v0.40.0golang.org/x/term: v0.38.0 → v0.39.0golang.org/x/text: v0.32.0 → v0.34.0golang.org/x/mod: v0.30.0 → v0.32.0golang.org/x/net: v0.48.0 → v0.49.0golang.org/x/tools: v0.39.0 → v0.41.0