OCPEDGE-2072: bump(ocp/api): pull in latest for DualReplica promotion by eggfoobar · Pull Request #10471 · openshift/installer

eggfoobar · 2026-04-07T14:55:03Z

No description provided.

openshift-ci-robot · 2026-04-07T14:55:14Z

@eggfoobar: This pull request references OCPEDGE-2072 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

eggfoobar · 2026-04-07T14:55:19Z

/hold

Waiting for API change to be merged into main

openshift-ci · 2026-04-07T14:55:47Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sadasu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coderabbitai · 2026-04-07T14:58:14Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6c96e210-5d45-4c84-9d90-db533b742930

📥 Commits

Reviewing files that changed from the base of the PR and between 0b5c45f and 3091227.

⛔ Files ignored due to path filters (21)

go.sum is excluded by !**/*.sum
vendor/github.com/openshift/api/config/v1/types.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/config/v1/types_authentication.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/config/v1/types_dns.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/config/v1/types_infrastructure.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/config/v1/zz_generated.deepcopy.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/config/v1/zz_generated.featuregated-crd-manifests.yaml is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/config/v1/zz_generated.swagger_doc_generated.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/config/v1alpha1/types_cluster_monitoring.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/config/v1alpha1/zz_generated.deepcopy.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/config/v1alpha1/zz_generated.swagger_doc_generated.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/features/features.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/machineconfiguration/v1/types.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/machineconfiguration/v1/types_machineconfignode.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/machineconfiguration/v1/zz_generated.featuregated-crd-manifests.yaml is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/machineconfiguration/v1/zz_generated.swagger_doc_generated.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/operator/v1/types_csi_cluster_driver.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/operator/v1/types_ingress.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/operator/v1/zz_generated.featuregated-crd-manifests.yaml is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/operator/v1/zz_generated.swagger_doc_generated.go is excluded by !vendor/**, !**/vendor/**
vendor/modules.txt is excluded by !vendor/**, !**/vendor/**

📒 Files selected for processing (3)

go.mod
pkg/asset/agent/installconfig_test.go
pkg/types/validation/featuregate_test.go

🚧 Files skipped from review as they are similar to previous changes (2)

pkg/types/validation/featuregate_test.go
go.mod

Walkthrough

Bumps github.com/openshift/api version in go.mod and updates two unit tests to accept ControlPlane fencing credentials under the default feature set.

Changes

Cohort / File(s)	Summary
Dependency Update `go.mod`	Updated `github.com/openshift/api` required version from `v0.0.0-20260318185450-1f2fa3f09f4e` to `v0.0.0-20260408092441-8b086e6b9eb9`. No other `go.mod` entries or `replace` directives changed.
Test expectation updates `pkg/asset/agent/installconfig_test.go`, `pkg/types/validation/featuregate_test.go`	Adjusted tests to expect successful validation when ControlPlane fencing credentials are present under the default feature set; updated expected `InstallConfig` in the agent installconfig test accordingly.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@go.mod`:
- Line 385: The replace directive "replace github.com/openshift/api =>
github.com/eggfoobar/api v0.0.0-20260406200249-1966dc1a21a7" needs an inline
temporary-comment and a tracking reference: add a one-line comment immediately
above that replace in go.mod stating this is a temporary fork, why it's needed,
and reference the tracking issue/PR ID (e.g. "TEMPORARY: using fork until
upstream change merged — tracking: GH-XXXX / JIRA-YYYY"). Also verify the fork's
accessibility (public vs private) and, if private, either make it accessible or
switch to a public mirror; finally ensure a real tracking mechanism exists
(create and link a GitHub issue or Jira ticket) so the replace can be removed
once upstream openshift/api is updated.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 55425338-cb61-405e-9fb5-59ae10b1a312

📥 Commits

Reviewing files that changed from the base of the PR and between d516a1e and aed58d7.

⛔ Files ignored due to path filters (21)

go.sum is excluded by !**/*.sum
vendor/github.com/openshift/api/config/v1/types.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/config/v1/types_authentication.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/config/v1/types_dns.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/config/v1/types_infrastructure.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/config/v1/zz_generated.deepcopy.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/config/v1/zz_generated.featuregated-crd-manifests.yaml is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/config/v1/zz_generated.swagger_doc_generated.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/config/v1alpha1/types_cluster_monitoring.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/config/v1alpha1/zz_generated.deepcopy.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/config/v1alpha1/zz_generated.swagger_doc_generated.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/features/features.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/machineconfiguration/v1/types.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/machineconfiguration/v1/types_machineconfignode.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/machineconfiguration/v1/zz_generated.featuregated-crd-manifests.yaml is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/machineconfiguration/v1/zz_generated.swagger_doc_generated.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/operator/v1/types_csi_cluster_driver.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/operator/v1/types_ingress.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/operator/v1/zz_generated.featuregated-crd-manifests.yaml is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift/api/operator/v1/zz_generated.swagger_doc_generated.go is excluded by !vendor/**, !**/vendor/**
vendor/modules.txt is excluded by !vendor/**, !**/vendor/**

📒 Files selected for processing (1)

go.mod

go.mod

coderabbitai

🧹 Nitpick comments (1)

pkg/types/validation/featuregate_test.go (1)

199-205: Pin the default feature set explicitly in this case.

The case name says "Default Feature Set", but it currently depends on validInstallConfig() defaults. Setting c.FeatureSet = v1.Default makes the scenario self-contained and prevents silent drift if that helper changes.

♻️ Proposed tweak

 		{
 			name: "FencingCredentials is allowed in Default Feature Set",
 			installConfig: func() *types.InstallConfig {
 				c := validInstallConfig()
+				c.FeatureSet = v1.Default
 				c.ControlPlane.Fencing = &types.Fencing{Credentials: []*types.Credential{{HostName: "host1"}, {HostName: "host2"}}}
 				return c
 			}(),
 		},

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@pkg/types/validation/featuregate_test.go` around lines 199 - 205, The test
relies on validInstallConfig() defaults but the case claims "Default Feature
Set"; update the test setup to explicitly pin the feature set by setting
c.FeatureSet = v1.Default after calling validInstallConfig() so the scenario is
self-contained and won't break if validInstallConfig() defaults change; modify
the anonymous installConfig func that creates c, locate the usage of
validInstallConfig(), and add c.FeatureSet = v1.Default (referencing c,
validInstallConfig, and types.Fencing/ControlPlane.Fencing) before returning c.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@pkg/types/validation/featuregate_test.go`:
- Around line 199-205: The test relies on validInstallConfig() defaults but the
case claims "Default Feature Set"; update the test setup to explicitly pin the
feature set by setting c.FeatureSet = v1.Default after calling
validInstallConfig() so the scenario is self-contained and won't break if
validInstallConfig() defaults change; modify the anonymous installConfig func
that creates c, locate the usage of validInstallConfig(), and add c.FeatureSet =
v1.Default (referencing c, validInstallConfig, and
types.Fencing/ControlPlane.Fencing) before returning c.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d71e99ae-69ba-440f-8982-d0880bb81a64

📥 Commits

Reviewing files that changed from the base of the PR and between aed58d7 and 0b5c45f.

📒 Files selected for processing (2)

pkg/asset/agent/installconfig_test.go
pkg/types/validation/featuregate_test.go

openshift-ci · 2026-04-07T19:42:38Z

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agent-compact-ipv4	`0b5c45f`	link	true	`/test e2e-agent-compact-ipv4`
ci/prow/golint	`0b5c45f`	link	true	`/test golint`
ci/prow/e2e-agent-two-node-fencing-ipv4	`0b5c45f`	link	false	`/test e2e-agent-two-node-fencing-ipv4`
ci/prow/e2e-agent-compact-ipv4-appliance-diskimage	`0b5c45f`	link	false	`/test e2e-agent-compact-ipv4-appliance-diskimage`
ci/prow/e2e-agent-compact-ipv6-minimaliso	`0b5c45f`	link	false	`/test e2e-agent-compact-ipv6-minimaliso`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Signed-off-by: ehila <ehila@redhat.com>

eggfoobar · 2026-04-08T10:42:01Z

/unhold
/verified by @eggfoobar with locally with custom payload using this PR openshift/cluster-etcd-operator#1587,openshift/api#2723,openshift/cluster-config-operator#480,#10471

openshift-ci-robot · 2026-04-08T10:42:13Z

@eggfoobar: This PR has been marked as verified by @eggfoobar with locally with custom payload using this PR openshift/cluster-etcd-operator#1587,openshift/api#2723,openshift/cluster-config-operator#480,openshift/installer#10471.

Details

In response to this:

/unhold
/verified by @eggfoobar with locally with custom payload using this PR openshift/cluster-etcd-operator#1587,openshift/api#2723,openshift/cluster-config-operator#480,#10471

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 7, 2026

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2026

openshift-ci bot requested review from pawanpinjarkar and rna-afk April 7, 2026 14:56

coderabbitai bot reviewed Apr 7, 2026

View reviewed changes

go.mod Outdated Show resolved Hide resolved

coderabbitai bot reviewed Apr 7, 2026

View reviewed changes

This was referenced Apr 7, 2026

OCPEDGE-2495: feat: update pacemaker in preparation for DualReplica promotion openshift/cluster-etcd-operator#1587

Merged

OCPEDGE-2197: Promote TNF (Dual Replica) to default openshift/api#2723

Merged

eggfoobar added 2 commits April 8, 2026 06:37

bump(ocp/api): pull in latest for DualReplica promotion

fa381f6

Signed-off-by: ehila <ehila@redhat.com>

fix: update unit tests to reflect DualReplica promotion

3091227

Signed-off-by: ehila <ehila@redhat.com>

eggfoobar force-pushed the bump-ocp-api branch from 0b5c45f to 3091227 Compare April 8, 2026 10:37

eggfoobar mentioned this pull request Apr 8, 2026

OCPEDGE-2071: bump(ocp/api): pull in latest for DualReplica promotion openshift/cluster-config-operator#480

Open

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPEDGE-2072: bump(ocp/api): pull in latest for DualReplica promotion#10471

OCPEDGE-2072: bump(ocp/api): pull in latest for DualReplica promotion#10471
eggfoobar wants to merge 2 commits intoopenshift:mainfrom
eggfoobar:bump-ocp-api

eggfoobar commented Apr 7, 2026

Uh oh!

openshift-ci-robot commented Apr 7, 2026 •

edited by openshift-ci bot

Loading

Uh oh!

eggfoobar commented Apr 7, 2026

Uh oh!

openshift-ci bot commented Apr 7, 2026

Uh oh!

coderabbitai bot commented Apr 7, 2026 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

openshift-ci bot commented Apr 7, 2026

Uh oh!

eggfoobar commented Apr 8, 2026

Uh oh!

openshift-ci-robot commented Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

eggfoobar commented Apr 7, 2026

Uh oh!

openshift-ci-robot commented Apr 7, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eggfoobar commented Apr 7, 2026

Uh oh!

openshift-ci bot commented Apr 7, 2026

Uh oh!

coderabbitai bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Apr 7, 2026

Uh oh!

eggfoobar commented Apr 8, 2026

Uh oh!

openshift-ci-robot commented Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

openshift-ci-robot commented Apr 7, 2026 •

edited by openshift-ci bot

Loading

coderabbitai bot commented Apr 7, 2026 •

edited

Loading