Skip to content

DNM: GCP: Increase bootstrap and cluster creation timeouts#10491

Open
sadasu wants to merge 1 commit intoopenshift:mainfrom
sadasu:gcp-custom-dns
Open

DNM: GCP: Increase bootstrap and cluster creation timeouts#10491
sadasu wants to merge 1 commit intoopenshift:mainfrom
sadasu:gcp-custom-dns

Conversation

@sadasu
Copy link
Copy Markdown
Contributor

@sadasu sadasu commented Apr 10, 2026

Do this only when userProvisioned DNS is enabled giving MCO additional time to bring up master nodes.

Do this only when userProvisioned DNS is enabled giving MCO
additional time to bring up master nodes.
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c15b3bf2-3112-44f2-b70d-cd1f1c2bc17f

📥 Commits

Reviewing files that changed from the base of the PR and between 4acb8b9 and f085757.

📒 Files selected for processing (2)
  • cmd/openshift-install/command/waitfor.go
  • cmd/openshift-install/create.go

Walkthrough

The changes add GCP platform support for user-provisioned DNS configuration in the cluster bootstrap timeout logic, making timeout behavior consistent across AWS and GCP platforms when user-provisioned DNS is enabled.

Changes

Cohort / File(s) Summary
Cluster Bootstrap Timeout Configuration
cmd/openshift-install/command/waitfor.go, cmd/openshift-install/create.go
Added GCP platform support for user-provisioned DNS timeout handling. Refactored AWS and GCP timeout logic from simple conditional checks to switch statement with conditional timeout increase (60 minutes) when user-provisioned DNS is enabled. Added logging for timeout configuration changes and updated platform-specific bootstrap timeout selection.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 10, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mtulio for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sadasu
Copy link
Copy Markdown
Contributor Author

sadasu commented Apr 10, 2026

/testwith openshift/installer/main/e2e-gcp-custom-dns openshift/cluster-ingress-operator#1411

@openshift-ci openshift-ci bot requested review from barbacbd and jhixson74 April 10, 2026 04:08
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 10, 2026

@sadasu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn f085757 link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sadasu sadasu changed the title GCP: Increase bootstrap and cluster creation timeouts DNM: GCP: Increase bootstrap and cluster creation timeouts Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant