SPLAT-2719: vsphere - remove HostGroup zonal feature gate checks

[jcpowermac]

Make HostGroup-based zonal failure domain handling always available in installer-owned validation and infrastructure manifest generation so users no longer need to enable VSphereHostVMGroupZonal.

Made-with: Cursor

Summary by CodeRabbit

• Features

  • vSphere host group zonal affinity configuration is now generally available without requiring feature gate activation. Host-VM-group-based zonal and regional affinity settings are automatically applied when using host group failure domain topology.

• Tests

  • Added test coverage for host group affinity configuration validation and functionality.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ca2e505d-78f8-473a-85fe-db436962b51e

📥 Commits

Reviewing files that changed from the base of the PR and between 52540f5 and 05cb449.

📒 Files selected for processing (4)

• pkg/asset/manifests/vsphere/infrastructure.go
• pkg/asset/manifests/vsphere/infrastructure_test.go
• pkg/types/validation/featuregate_test.go
• pkg/types/vsphere/validation/featuregates.go

💤 Files with no reviewable changes (1)

• pkg/types/vsphere/validation/featuregates.go

---

Walkthrough

The pull request removes the FeatureGateVSphereHostVMGroupZonal feature gate, making VSphere host-VM-group-based zonal affinity configuration unconditionally available. Feature gate definition and related conditional logic are deleted, and test coverage is added to validate the now-permanent behavior.

Changes

Cohort / File(s)	Summary
Feature Gate Removal pkg/asset/manifests/vsphere/infrastructure.go, pkg/types/vsphere/validation/featuregates.go	Removed FeatureGateVSphereHostVMGroupZonal gating logic and gate definition. Zonal affinity configuration for host-VM groups now occurs unconditionally when failureDomain.ZoneType matches the host group failure domain type.
Test Coverage pkg/asset/manifests/vsphere/infrastructure_test.go, pkg/types/validation/featuregate_test.go	Added new test function TestGetInfraPlatformSpecHostGroupAffinity validating host group affinity configuration, and added test case verifying vSphere HostGroup zonal configuration passes validation with default feature set (without requiring explicit feature gate enablement).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 8 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Test Structure And Quality	❓ Inconclusive	Custom check for Ginkgo test quality cannot be applied because the actual tests use standard Go testing patterns, not Ginkgo framework, and infrastructure_test.go does not exist in the repository.	Verify whether infrastructure_test.go should exist and confirm if test quality assessment should evaluate standard Go tests rather than Ginkgo-specific code patterns.

✅ Passed checks (8 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and specifically describes the main change: removing the HostGroup zonal feature gate checks from vSphere infrastructure handling.
Stable And Deterministic Test Names	✅ Passed	All test names in modified test files are static, descriptive strings with no dynamic values, timestamps, or generated identifiers.
Microshift Test Compatibility	✅ Passed	The new tests added are standard Go unit tests, not Ginkgo e2e tests. They do not use Ginkgo-specific patterns or APIs.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR adds only standard Go unit tests, not Ginkgo e2e tests, so SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	PR removes feature gate check for vSphere failure domain configuration. Changes are infrastructure-level (vSphere VM-to-host affinity in vCenter), not Kubernetes pod scheduling constraints. No pod manifests, operator code, or scheduling constraints are modified.
Ote Binary Stdout Contract	✅ Passed	No process-level stdout writes found; changes only modify infrastructure generation and test cases without affecting OTE binary stdout contract.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Tests added are standard Go unit tests, not Ginkgo e2e tests, so the custom check does not apply.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@jcpowermac: This pull request references SPLAT-2719 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.22." or "openshift-4.22.", but it targets "openshift-5.0" instead.

Details

In response to this:

Make HostGroup-based zonal failure domain handling always available in installer-owned validation and infrastructure manifest generation so users no longer need to enable VSphereHostVMGroupZonal.

Made-with: Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tthvo]

/retest

[tthvo]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tthvo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [tthvo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jcpowermac]

/verified by @jcpowermac via ci

[openshift-ci-robot]

@jcpowermac: This PR has been marked as verified by @jcpowermac via ci.

Details

In response to this:

/verified by @jcpowermac via ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@jcpowermac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-ovn-devpreview	05cb449	link	false	/test e2e-vsphere-ovn-devpreview
ci/prow/e2e-vsphere-ovn-disk-setup-techpreview	05cb449	link	false	/test e2e-vsphere-ovn-disk-setup-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.