[release-4.21] OCPBUGS-84225: ibmcloud: bump vpc-go-sdk and capibm#10514
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @Pacho20. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
fd96427 to
664a946
Compare
|
/jira cherrypick OCPBUGS-84088 |
|
@Pacho20: Jira Issue OCPBUGS-84088 has been cloned as Jira Issue OCPBUGS-84225. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@Pacho20: This pull request references Jira Issue OCPBUGS-84225, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@Pacho20: This pull request references Jira Issue OCPBUGS-84225, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-powervs-capi-ovn |
|
/ok-to-test |
|
The installer team prefers the commits to be separated into two commits
|
|
/test e2e-powervs-capi-ovn |
The newer API versions of the vpc contains some breaking changes for SecurityGroupRuleProtocol. Some older SDKs was patched to handle additional protocol values introduced in newer API versions, ensuring older SDK releases do not fail when reading security group or network ACL rules created with expanded protocol support. The latest release of v0.10 of the cluster-api-provider-ibmcloud uses one of the patched SDKs. This update allows the installer to continue functioning with the changes.
SDK Compatibility Patch - Protocol Handling The SDK was patched to handle additional protocol values introduced in newer API versions, ensuring older SDK releases do not fail when reading security group or network ACL rules created with expanded protocol support.
664a946 to
75f444e
Compare
|
/test e2e-powervs-capi-ovn |
1 similar comment
|
/test e2e-powervs-capi-ovn |
|
@Pacho20: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm Failure seems unrelated. Thanks for the patience. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by CI. |
|
@sadasu: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label backport-risk-assessed |
9a415c4
into
openshift:release-4.21
|
@Pacho20: Jira Issue Verification Checks: Jira Issue OCPBUGS-84225 Jira Issue OCPBUGS-84225 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Bumping the vpc go sdk to v0.71.2. This contains a fix for a recent VPC API breaking change.
Also Bumping the capibm version to the latest commit on the https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/tree/release-0.10 branch. This is the same release of the currently used capibm with some patches that also contains the VPC API fix.