Skip to content

[release-4.22] OCPBUGS-84663: add unit tests for Nutanix to replace polarion workitems#10525

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-10520-to-release-4.22
Apr 29, 2026
Merged

[release-4.22] OCPBUGS-84663: add unit tests for Nutanix to replace polarion workitems#10525
openshift-merge-bot[bot] merged 2 commits intoopenshift:release-4.22from
openshift-cherrypick-robot:cherry-pick-10520-to-release-4.22

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Apr 29, 2026

This is an automated cherry-pick of #10520

/assign jcpowermac

jcpowermac and others added 2 commits April 29, 2026 09:19
@jcpowermac @claude
unit tests: add comprehensive Nutanix platform validation and machine…
cf6cab6 
… generation tests

Add unit tests covering Nutanix platform validation, machine pool
validation, machine generation, machineset generation, and RHCOS image
naming. Key additions:

- Platform validation: Prism Central/Element endpoint, port range,
  subnet, failure domain, load balancer, DNS records, and API timeout
- Machine pool validation: CPU, memory, disk, boot type, project,
  GPU (with httptest fake server), category (with httptest fake server),
  and data disk device/adapter/storage config
- Machine generation: GPU propagation, multi-subnet/multi-NIC,
  ControlPlaneMachineSet metadata/state/failure domains, and preloaded
  OS image name passthrough
- MachineSets: compact cluster, single/multi failure domain via
  defaultMachinePlatform and explicit pool config, replica handling

Also fixes typo "projct" → "project" in validateProjectConfig error
messages and changes Prism Element port validation from field.Required
to field.Invalid to match Prism Central behavior.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jcpowermac @claude
chore: suppress revive var-naming lint for tls test package
f861c08 
The package name matches the directory and is required for white-box
test access to unexported symbols.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 29, 2026
Merged
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7472edd8-8c53-4bba-be54-8673f444d3c7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from andfasano and jcpowermac April 29, 2026 09:19
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 29, 2026

@openshift-cherrypick-robot: Jira Issue OCPBUGS-84548 has been cloned as Jira Issue OCPBUGS-84663. Will retitle bug to link to clone.
/retitle [release-4.22] OCPBUGS-84663: add unit tests for Nutanix to replace polarion workitems

Details

In response to this:

This is an automated cherry-pick of #10520

/assign jcpowermac

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.22] OCPBUGS-84548: add unit tests for Nutanix to replace polarion workitems [release-4.22] OCPBUGS-84663: add unit tests for Nutanix to replace polarion workitems Apr 29, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 29, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 29, 2026

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-84663, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-84548 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-84548 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #10520

/assign jcpowermac

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcpowermac
Copy link
Copy Markdown
Contributor

jcpowermac commented Apr 29, 2026

/verified by @jcpowermac via unit

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 29, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 29, 2026

@jcpowermac: This PR has been marked as verified by @jcpowermac via unit.

Details

In response to this:

/verified by @jcpowermac via unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vr4manta
Copy link
Copy Markdown
Contributor

vr4manta commented Apr 29, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2026
tthvo
tthvo reviewed Apr 29, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tthvo
Copy link
Copy Markdown
Member

tthvo commented Apr 29, 2026

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tthvo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2026
@sadasu
Copy link
Copy Markdown
Contributor

sadasu commented Apr 29, 2026

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 29, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 5b9847e into openshift:release-4.22 Apr 29, 2026
17 checks passed
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 29, 2026

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-84663
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-84663 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #10520

/assign jcpowermac

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Apr 30, 2026

Fix included in release 4.22.0-0.nightly-2026-04-29-224558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andfasano andfasano Awaiting requested review from andfasano

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

1 more reviewer

@tthvo tthvo tthvo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jcpowermac jcpowermac

@vr4manta vr4manta

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@openshift-cherrypick-robot @openshift-ci-robot @jcpowermac @vr4manta @tthvo @sadasu @openshift-merge-robot