[release-4.22] OCPBUGS-84701: vSphere - Missing unit tests to cover polarion workitems#10526
Conversation
Add comprehensive unit tests across vSphere platform validation, machine generation, and cluster destroy: - Machine generation: multi-NIC, multi-zone, hardware config propagation, pre-existing RHCOS template, multi-vCenter workspace server, host group and VMGroup propagation, failure domain auto-population - MachineSet generation: single zone, multizone ControlPlaneMachineSet, static IP AddressesFromPools, multi-zone template propagation - Platform validation: invalid IPI options, topology field validation, datastore cluster paths, customized folder paths, data disk count and name length, datacenter and computeCluster validation - Machine pool validation: data disk count and name length - Scheduler: mastersSchedulable for compact 3-node clusters - Cluster destroy: CNS volume deletion - DNS validation: external DNS records with load balancer Fix gofmt struct field alignment in machines_test.go and scheduler_test.go. Fix misleading assertion message in scheduler_test.go where the format string referenced "compute replicas total" but received the test case name. Fix shared mutable package-level fixture machineComputePoolNoZones whose Zones field was mutated by MachineSets(), replacing it with a per-test inline construction. Add test case for nil Replicas in compute pool to lock current behavior. Add guard assertion for empty Network.Devices in static IP test. Scope CNS volume test mock expectations per-subtest with explicit Times() calls to prevent false-pass on missing delete calls. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/verified by @jcpowermac via unit test |
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-84335 has been cloned as Jira Issue OCPBUGS-84701. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
changed the title
openshift-ci-robot
added
the
verified
|
@jcpowermac: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
jira/severity-critical
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-84701, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test gofmt shellcheck yaml-lint |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tthvo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/label backport-risk-assessed |
openshift-ci
Bot
added
the
backport-risk-assessed
|
/retest-required |
|
/override ci/prow/e2e-vsphere-ovn This change only affects tests (a bit of validation, but install completes in the latest run). Let's not stress infra too much XD |
|
@tthvo: Overrode contexts on behalf of tthvo: ci/prow/e2e-vsphere-ovn DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/tide refresh |
openshift-merge-bot
Bot
merged commit b8a967b
into
openshift:release-4.22
|
@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-84701 Jira Issue OCPBUGS-84701 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
5 participants
This is an automated cherry-pick of #10516
/assign jcpowermac