Skip to content

OCPBUGS-85232: PowerVS: Add port 80 security group rule#10541

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
mjturek:add-port-80-rule
May 9, 2026
Merged

OCPBUGS-85232: PowerVS: Add port 80 security group rule#10541
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
mjturek:add-port-80-rule

Conversation

@mjturek
Copy link
Copy Markdown
Contributor

@mjturek mjturek commented May 8, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Added TCP port 80 to the required security group rules for PowerVS VPC configurations to ensure proper HTTP connectivity.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 8, 2026

Walkthrough

The findMissingSecurityGroupRules function in the PowerVS cluster API now treats TCP port 80 as a required port for the PowerVS VPC security group, adding it to the existing set of required ports: 22, 443, 5000, 6443, 10258, and 22623.

Changes

Cohort / File(s) Summary
PowerVS Security Group Configuration
pkg/infrastructure/powervs/clusterapi/powervs.go
Added TCP port 80 to the list of required security group rules for PowerVS VPC.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies production code only (powervs.go). No Ginkgo tests are added, modified, or affected. Check is not applicable.
Test Structure And Quality ✅ Passed PR adds port 80 to PowerVS security group rules in a new implementation file. No Ginkgo test code exists in this PR to review against test quality requirements.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests added. Check only applies to new test functions. PR modifies infrastructure code to add port 80 to security group rules.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR modifies production infrastructure code (powervs.go) to add port 80 to security group rules. No Ginkgo e2e tests are added, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Infrastructure provisioning code adding port 80 to PowerVS security group rules. No scheduling constructs, affinity, topology logic, or replica configuration present.
Ote Binary Stdout Contract ✅ Passed Not applicable. PR modifies infrastructure code only. OTE check applies to test binaries with main/init functions. File has neither and no stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Custom check not applicable. PR modifies infrastructure provider code, not e2e tests. The check applies only when new Ginkgo e2e tests are added; no tests are present in this PR.
Title check ✅ Passed The title clearly and specifically describes the main change: adding port 80 to PowerVS security group rules.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from hamzy and mkumatag May 8, 2026 14:40
@mjturek
Copy link
Copy Markdown
Contributor Author

mjturek commented May 8, 2026

/test e2e-powervs-capi-ovn

@mjturek
Copy link
Copy Markdown
Contributor Author

mjturek commented May 8, 2026

/assign hamzy

@hamzy
Copy link
Copy Markdown
Contributor

hamzy commented May 8, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2026
@mjturek mjturek changed the title PowerVS: Add port 80 security group rule OCPBUGS-85232: PowerVS: Add port 80 security group rule May 8, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 8, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@mjturek: This pull request references Jira Issue OCPBUGS-85232, which is invalid:

  • expected the bug to target only the "5.0.0" version, but multiple target versions were set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary by CodeRabbit

  • Bug Fixes
  • Added TCP port 80 to the required security group rules for PowerVS VPC configurations to ensure proper HTTP connectivity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mjturek
Copy link
Copy Markdown
Contributor Author

mjturek commented May 8, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 8, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@mjturek: This pull request references Jira Issue OCPBUGS-85232, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mjturek
Copy link
Copy Markdown
Contributor Author

mjturek commented May 8, 2026

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 8, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjturek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2026
@prb112
Copy link
Copy Markdown
Contributor

prb112 commented May 8, 2026

/verified by @prb112

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 8, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@prb112: This PR has been marked as verified by @prb112.

Details

In response to this:

/verified by @prb112

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD c782a19 and 2 for PR HEAD 0611897 in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 9, 2026

@mjturek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-powervs-capi-ovn 0611897 link false /test e2e-powervs-capi-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 51977d8 into openshift:main May 9, 2026
15 of 16 checks passed
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@mjturek: Jira Issue Verification Checks: Jira Issue OCPBUGS-85232
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-85232 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Summary by CodeRabbit

  • Bug Fixes
  • Added TCP port 80 to the required security group rules for PowerVS VPC configurations to ensure proper HTTP connectivity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants