OCPBUGS-86552: azure: Add field in installconfig to disallow shared access key by rna-afk · Pull Request #10575 · openshift/installer

rna-afk · 2026-05-26T19:56:08Z

Since this needs to be backported to earlier versions, adding a
field to disallow shared access key if necessary.

Made the field negative type field to have the default be enabled for
shared key access for earlier versions.

- When using a managed identity, don't use shared key credentials - SAS urls are not supported in this case, so just return the blob URL https://issues.redhat.com/browse/OCPBUGS-37587

Removing the option to add shared key credentials to make way for better cred authentications.

Creating SAS url for ignition blobs using user delegated credentials.

Since this needs to be backported to earlier versions, adding a field to disallow shared access key if necessary. Made the field negative type field to have the default be enabled for shared key access for earlier versions.

openshift-ci-robot · 2026-05-26T19:56:15Z

@rna-afk: This pull request references Jira Issue OCPBUGS-86552, which is invalid:

expected dependent Jira Issue OCPBUGS-82068 to target a version in 4.21.0, 4.21.z, but it targets "4.21" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Since this needs to be backported to earlier versions, adding a
field to disallow shared access key if necessary.

Made the field negative type field to have the default be enabled for
shared key access for earlier versions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-05-26T19:56:17Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c9993fe0-78ee-40dc-aa15-cd5aa49aa4bf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-05-26T19:57:14Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rna-afk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rna-afk · 2026-05-26T19:57:24Z

/jira refresh

openshift-ci-robot · 2026-05-26T19:57:29Z

@rna-afk: This pull request references Jira Issue OCPBUGS-86552, which is invalid:

expected dependent Jira Issue OCPBUGS-82068 to target a version in 4.21.0, 4.21.z, but it targets "4.21" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rna-afk · 2026-05-26T19:58:41Z

/jira refresh

openshift-ci-robot · 2026-05-26T19:58:49Z

@rna-afk: This pull request references Jira Issue OCPBUGS-86552, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.z) matches configured target version for branch (4.20.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-82068 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-82068 targets the "4.21.z" version, which is one of the valid target versions: 4.21.0, 4.21.z
bug has dependents

Requesting review from QA contact:
/cc @jinyunma

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-05-26T19:58:52Z

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: jinyunma.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@rna-afk: This pull request references Jira Issue OCPBUGS-86552, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)

bug target version (4.20.z) matches configured target version for branch (4.20.z)

bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

release note text is set and does not match the template

dependent bug Jira Issue OCPBUGS-82068 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))

dependent Jira Issue OCPBUGS-82068 targets the "4.21.z" version, which is one of the valid target versions: 4.21.0, 4.21.z

bug has dependents

Requesting review from QA contact:
/cc @jinyunma

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-05-27T00:03:16Z

@rna-afk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azurestack	`6136231`	link	false	`/test e2e-azurestack`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jhixson74 and others added 4 commits May 26, 2026 15:30

pkg/infrastructure/azure: don't use shared key auth

0c8d4e6

- When using a managed identity, don't use shared key credentials - SAS urls are not supported in this case, so just return the blob URL https://issues.redhat.com/browse/OCPBUGS-37587

azure: Remove option to add shared key creds

4437737

Removing the option to add shared key credentials to make way for better cred authentications.

azure: Create SAS for blobs

6735d8f

Creating SAS url for ignition blobs using user delegated credentials.

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 26, 2026

openshift-ci Bot requested review from jhixson74 and rwsu May 26, 2026 19:57

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 26, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-86552: azure: Add field in installconfig to disallow shared access key#10575

OCPBUGS-86552: azure: Add field in installconfig to disallow shared access key#10575
rna-afk wants to merge 4 commits into
openshift:release-4.20from
rna-afk:cherry_pick_sas_4.20

rna-afk commented May 26, 2026

Uh oh!

openshift-ci-robot commented May 26, 2026

Uh oh!

coderabbitai Bot commented May 26, 2026

Review skipped

Uh oh!

openshift-ci Bot commented May 26, 2026

Uh oh!

rna-afk commented May 26, 2026

Uh oh!

openshift-ci-robot commented May 26, 2026

Uh oh!

rna-afk commented May 26, 2026

Uh oh!

openshift-ci-robot commented May 26, 2026

Uh oh!

openshift-ci Bot commented May 26, 2026

Uh oh!

openshift-ci Bot commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

rna-afk commented May 26, 2026

Uh oh!

openshift-ci-robot commented May 26, 2026

Uh oh!

coderabbitai Bot commented May 26, 2026

Review skipped

Uh oh!

openshift-ci Bot commented May 26, 2026

Uh oh!

rna-afk commented May 26, 2026

Uh oh!

openshift-ci-robot commented May 26, 2026

Uh oh!

rna-afk commented May 26, 2026

Uh oh!

openshift-ci-robot commented May 26, 2026

Uh oh!

openshift-ci Bot commented May 26, 2026

Uh oh!

openshift-ci Bot commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants