MCO-2296: Remove OSImageStreams v1 replace#10592
Conversation
This change removes the temporary replace directives added to bump OSImageStream to v1. Signed-off-by: Pablo Rodriguez Nava <git@amail.pablintino.eu>
|
@pablintino: This pull request references MCO-2296 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note
|
| Layer / File(s) | Summary |
|---|---|
API and client-go version bumps with fork removal go.mod |
github.com/openshift/api and github.com/openshift/client-go versions updated to newer pseudo-versions; replace directives pointing to github.com/pablintino/* forks removed. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
- openshift/installer#10566: Earlier PR that similarly updated openshift/api and openshift/client-go versions and manages replace directives for pablintino fork references.
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title accurately describes the main change: removing replace directives for OpenShift API and client-go dependencies that pointed to forked versions. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Stable And Deterministic Test Names | ✅ Passed | No Ginkgo tests found in codebase. Repository uses standard Go testing.T framework. The custom check for Ginkgo test names is not applicable to this PR. |
| Test Structure And Quality | ✅ Passed | PR only modifies go.mod (dependency versions and replace directives). No test files are changed, making the Ginkgo test quality check inapplicable to this PR. |
| Microshift Test Compatibility | ✅ Passed | No new Ginkgo e2e tests are added in this PR—only go.mod dependency updates and CI config changes. The check does not apply since it targets new test additions. |
| Single Node Openshift (Sno) Test Compatibility | ✅ Passed | PR is a dependency management change (go.mod/go.sum) removing replace directives. No new Ginkgo e2e tests are added, making the SNO test compatibility check not applicable. |
| Topology-Aware Scheduling Compatibility | ✅ Passed | PR only modifies go.mod (dependency management), not deployment manifests, operator code, or controllers. Check is inapplicable to dependency updates. |
| Ote Binary Stdout Contract | ✅ Passed | PR only modifies go.mod dependencies and remove replace directives; no new Go code added that could write to stdout in process-level contexts. |
| Ipv6 And Disconnected Network Test Compatibility | ✅ Passed | This PR only modifies go.mod dependencies; no new Ginkgo e2e tests (It(), Describe(), Context(), etc.) are added, so the IPv6/disconnected network compatibility check is not applicable. |
| No-Weak-Crypto | ✅ Passed | PR modifies only go.mod dependencies with no cryptographic code changes. No weak crypto patterns detected in codebase. |
| Container-Privileges | ✅ Passed | PR only modifies go.mod to remove replace directives; no K8s manifests with privileged container settings (privileged:true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation) found. |
| No-Sensitive-Data-In-Logs | ✅ Passed | PR contains no logging statements that expose sensitive data like passwords, tokens, API keys, or PII. Changes are primarily dependency updates and documentation files. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Warning
There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.
🔧 golangci-lint (2.12.2)
Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
Comment @coderabbitai help to get the list of available commands and usage tips.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/label approved Just clearing up a mess we made earlier /verified by CI Shouldn't need extensive verification for a small vendor change like this |
|
@JoelSpeed: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@pablintino: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This change removes the temporary replace directives added to bump OSImageStream to v1.
Summary by CodeRabbit