Skip to content

OCPBUGS-87169: CVE-2026-34986: Bump go-jose/v4 to 4.1.4#10596

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
rh-akhatavk:main
Jun 5, 2026
Merged

OCPBUGS-87169: CVE-2026-34986: Bump go-jose/v4 to 4.1.4#10596
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
rh-akhatavk:main

Conversation

@rh-akhatavk
Copy link
Copy Markdown
Contributor

@rh-akhatavk rh-akhatavk commented Jun 4, 2026

Bumps go-jose/v4 to 4.1.4 to fix CVE-2026-34986

Summary by CodeRabbit

  • Chores
    • Updated dependencies to latest compatible versions.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 4, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rh-akhatavk: This pull request explicitly references no jira issue.

Details

In response to this:

Bumps go-jose/v4 to 4.1.4 to fix CVE-2026-34986

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key: "tools"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
📝 Walkthrough

Walkthrough

The indirect dependency github.com/go-jose/go-jose/v4 is bumped from version v4.1.3 to v4.1.4 in go.mod. This is a patch version update with no structural or declarative changes to the OpenShift installer codebase itself.

Changes

Dependency Update

Layer / File(s) Summary
go-jose indirect dependency version bump
go.mod
Indirect dependency github.com/go-jose/go-jose/v4 updated from v4.1.3 to v4.1.4.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only updates go-jose/v4 dependency version in go.mod (v4.1.3→v4.1.4). No test files were modified, and no Ginkgo test names are present in the changes.
Test Structure And Quality ✅ Passed PR only updates go.mod dependency version; no test code changes. Custom check for Ginkgo test code quality is not applicable to this dependency version bump.
Microshift Test Compatibility ✅ Passed PR only updates go.mod dependency version (go-jose/v4 v4.1.3→v4.1.4). No new Ginkgo e2e tests (It/Describe/Context/When) were added; test files use standard Go testing framework.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only updates a Go dependency (go-jose/v4 from v4.1.3 to v4.1.4) in go.mod. No new Ginkgo e2e tests were added, so the SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR is a CVE security patch bumping go-jose/v4 dependency; no deployment manifests, operator specs, or controller scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed PR only updates go.mod dependency version (go-jose v4.1.3→v4.1.4) with no source code changes, therefore no process-level stdout writes introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only updates go-jose/v4 dependency version in go.mod; no new Ginkgo e2e tests added, so check doesn't apply.
No-Weak-Crypto ✅ Passed PR updates go-jose/v4 to v4.1.4 fixing CVE-2026-34986 (DoS, not crypto weakness). No weak algorithms or custom crypto detected in codebase.
Container-Privileges ✅ Passed PR bumps go-jose/v4 for CVE-2026-34986. "privileged: true" additions are only in documentation and Vagrant files, not K8s manifests. Deployed manifests have no unsafe container privileges.
No-Sensitive-Data-In-Logs ✅ Passed PR only updates go.mod dependency version (v4.1.3→v4.1.4) with no new code or logging statements that could expose sensitive data.
Title check ✅ Passed The title clearly identifies the main change: bumping go-jose/v4 to 4.1.4 for CVE-2026-34986. It's specific, concise, and directly reflects the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from barbacbd and sadasu June 4, 2026 11:52
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 4, 2026

@rh-akhatavk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Copy Markdown
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tthvo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2026
@tthvo
Copy link
Copy Markdown
Member

tthvo commented Jun 4, 2026

/retitle OCPBUGS-87169: CVE-2026-34986: Bump go-jose/v4 to 4.1.4

@openshift-ci openshift-ci Bot changed the title NO-JIRA: Bump go-jose/v4 to 4.1.4 OCPBUGS-87169: CVE-2026-34986: Bump go-jose/v4 to 4.1.4 Jun 4, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 4, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rh-akhatavk: This pull request references Jira Issue OCPBUGS-87169, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bumps go-jose/v4 to 4.1.4 to fix CVE-2026-34986

Summary by CodeRabbit

  • Chores
  • Updated dependencies to latest compatible versions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tthvo
Copy link
Copy Markdown
Member

tthvo commented Jun 4, 2026

@rh-akhatavk I created OCPBUGS-87169 targetting 5.0.0 in order to complete the bug chain requirement 👍 Can you help verify and add the verified label?

@rh-akhatavk
Copy link
Copy Markdown
Contributor Author

Sure 👍

@sbiradar10
Copy link
Copy Markdown

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jun 5, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@sbiradar10: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit 35013a5 into openshift:main Jun 5, 2026
15 checks passed
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rh-akhatavk: Jira Issue OCPBUGS-87169: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-87169 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

Details

In response to this:

Bumps go-jose/v4 to 4.1.4 to fix CVE-2026-34986

Summary by CodeRabbit

  • Chores
  • Updated dependencies to latest compatible versions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rh-akhatavk
Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rh-akhatavk: Jira Issue OCPBUGS-87169: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-87169 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rh-akhatavk
Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rh-akhatavk: Jira Issue Verification Checks: Jira Issue OCPBUGS-87169
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-87169 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

Fix included in release 5.0.0-0.nightly-2026-06-06-100407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants