Skip to content

Add tzdata to openstack image#10600

Open
hamzy wants to merge 1 commit into
openshift:mainfrom
hamzy:Add-tzdata-openstack-images
Open

Add tzdata to openstack image#10600
hamzy wants to merge 1 commit into
openshift:mainfrom
hamzy:Add-tzdata-openstack-images

Conversation

@hamzy
Copy link
Copy Markdown
Contributor

@hamzy hamzy commented Jun 5, 2026

When running the openstack CLI, I see the following errors:

Could not load 'flavor_create': [Errno 2] No such file or directory: '/usr/share/zoneinfo/zone.tab'

So add the tzdata rpm during the container build.

Summary by CodeRabbit

  • Chores
    • Updated CI environment dependencies.

When running the openstack CLI, I see the following errors:
```
Could not load 'flavor_create': [Errno 2] No such file or directory: '/usr/share/zoneinfo/zone.tab'
```

So add the tzdata rpm during the container build.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 5, 2026

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key: "tools"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8ba61c5c-d62e-4ccf-a690-f935649959c5

📥 Commits

Reviewing files that changed from the base of the PR and between 35013a5 and dc4f08f.

📒 Files selected for processing (1)
  • images/openstack/Dockerfile.ci

📝 Walkthrough

Walkthrough

The OpenStack CI Docker image now installs tzdata as a base package dependency. This adds timezone database support to the CI test environment without changes to the image's build logic, copy operations, or runtime configuration.

Changes

CI Docker Image Dependencies

Layer / File(s) Summary
tzdata package installation
images/openstack/Dockerfile.ci
tzdata is added to the yum install command in the CI Docker build to provide timezone data runtime support.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and concisely describes the main change: adding tzdata to the openstack image. It accurately reflects the single-line addition in the Dockerfile.ci file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR adds tzdata to OpenStack Dockerfile only; no Ginkgo tests added or modified, making the test naming check not applicable.
Test Structure And Quality ✅ Passed The custom check seeks to review Ginkgo test code quality, but this PR only modifies images/openstack/Dockerfile.ci (adding tzdata package). No test files or Ginkgo code are present.
Microshift Test Compatibility ✅ Passed No Ginkgo e2e tests are added in this PR; it only modifies a Dockerfile to install tzdata. The MicroShift test compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only images/openstack/Dockerfile.ci (adding tzdata package); no new Ginkgo e2e tests are added, so SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies a Dockerfile (not a deployment manifest, operator code, or controller). The check's scope explicitly covers only those three artifact types. No scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed PR modifies only Dockerfile.ci infrastructure code to add tzdata RPM package; no Go code or executable logic is changed that could affect OTE binary stdout contracts.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only modifies images/openstack/Dockerfile.ci to add tzdata package; no Ginkgo e2e tests added, so IPv6/disconnected network compatibility check is not applicable.
No-Weak-Crypto ✅ Passed PR only adds tzdata package to Dockerfile.ci for timezone support; no weak cryptographic patterns (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB) or custom crypto implementations detected.
Container-Privileges ✅ Passed Dockerfile runs as non-root user (UID 1000:1000) with no privileged flags, hostPID/Network/IPC, or capability escalations detected. PR only adds tzdata package dependency.
No-Sensitive-Data-In-Logs ✅ Passed No logging statements, credentials, or sensitive data exposed in code changes; tzdata addition is a benign package installation with no logging implications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gryf for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from gryf and mandre June 5, 2026 20:35
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 6, 2026

@hamzy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-dualstack-upi dc4f08f link false /test e2e-openstack-dualstack-upi
ci/prow/e2e-openstack-ovn dc4f08f link true /test e2e-openstack-ovn
ci/prow/e2e-openstack-proxy dc4f08f link false /test e2e-openstack-proxy

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant