Add tzdata to openstack image#10600
Conversation
When running the openstack CLI, I see the following errors: ``` Could not load 'flavor_create': [Errno 2] No such file or directory: '/usr/share/zoneinfo/zone.tab' ``` So add the tzdata rpm during the container build.
|
Note
|
| Layer / File(s) | Summary |
|---|---|
tzdata package installation images/openstack/Dockerfile.ci |
tzdata is added to the yum install command in the CI Docker build to provide timezone data runtime support. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title directly and concisely describes the main change: adding tzdata to the openstack image. It accurately reflects the single-line addition in the Dockerfile.ci file. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Stable And Deterministic Test Names | ✅ Passed | PR adds tzdata to OpenStack Dockerfile only; no Ginkgo tests added or modified, making the test naming check not applicable. |
| Test Structure And Quality | ✅ Passed | The custom check seeks to review Ginkgo test code quality, but this PR only modifies images/openstack/Dockerfile.ci (adding tzdata package). No test files or Ginkgo code are present. |
| Microshift Test Compatibility | ✅ Passed | No Ginkgo e2e tests are added in this PR; it only modifies a Dockerfile to install tzdata. The MicroShift test compatibility check does not apply. |
| Single Node Openshift (Sno) Test Compatibility | ✅ Passed | PR modifies only images/openstack/Dockerfile.ci (adding tzdata package); no new Ginkgo e2e tests are added, so SNO compatibility check does not apply. |
| Topology-Aware Scheduling Compatibility | ✅ Passed | PR modifies a Dockerfile (not a deployment manifest, operator code, or controller). The check's scope explicitly covers only those three artifact types. No scheduling constraints are introduced. |
| Ote Binary Stdout Contract | ✅ Passed | PR modifies only Dockerfile.ci infrastructure code to add tzdata RPM package; no Go code or executable logic is changed that could affect OTE binary stdout contracts. |
| Ipv6 And Disconnected Network Test Compatibility | ✅ Passed | PR only modifies images/openstack/Dockerfile.ci to add tzdata package; no Ginkgo e2e tests added, so IPv6/disconnected network compatibility check is not applicable. |
| No-Weak-Crypto | ✅ Passed | PR only adds tzdata package to Dockerfile.ci for timezone support; no weak cryptographic patterns (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB) or custom crypto implementations detected. |
| Container-Privileges | ✅ Passed | Dockerfile runs as non-root user (UID 1000:1000) with no privileged flags, hostPID/Network/IPC, or capability escalations detected. PR only adds tzdata package dependency. |
| No-Sensitive-Data-In-Logs | ✅ Passed | No logging statements, credentials, or sensitive data exposed in code changes; tzdata addition is a benign package installation with no logging implications. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Comment @coderabbitai help to get the list of available commands and usage tips.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@hamzy: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
When running the openstack CLI, I see the following errors:
So add the tzdata rpm during the container build.
Summary by CodeRabbit