hack: remove compile time RELEASE_IMAGE override#2217
hack: remove compile time RELEASE_IMAGE override#2217openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
|
/assign @abhinavdahiya |
openshift-ci-robot
added
the
size/XS
|
/lgtm |
openshift-ci-robot
added
lgtm
|
We might be able to drop this, if /hold |
openshift-ci-robot
added
the
do-not-merge/hold
The location of the defaultReleaseImage variable has moved to pkg/asset/releaseimage, and this doesn't currently work. It also appears nothing is relying on this feature so we can remove it. If you want to override the release image, you can do at run time with OPENSHIFT_RELEASE_IMAGE_OVERRIDE, which functions the same other than not being embedded in the produced openshift-install binary.
stbenjam
force-pushed
the
fix-release-image-override
branch
from
7db394d to
0c706c4
Compare
stbenjam
changed the title
|
@abhinavdahiya Setting the release image at run time works fine for us, so I've changed this to remove the code entirely. PTAL. /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/assign @wking LGTM |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@stbenjam: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
6 participants
The location of the defaultReleaseImage variable has moved to
pkg/asset/releaseimage, and this doesn't currently work. It also appears
nothing is relying on this feature so we can remove it. If you want to
override the release image, you can do at run time with
OPENSHIFT_RELEASE_IMAGE_OVERRIDE, which functions the same other than
not being embedded in the produced openshift-install binary.