Fix Azure cloud provider subnet reference#2556
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Oct 24, 2019
Merged
Fix Azure cloud provider subnet reference#2556openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
On Azure, the installer is configuring the cloud provider with a subnet using a `-node-subnet` suffix. This is incorrect, as the actual subnet created for Azure has a `-worker-subnet` suffix. The cloud provider refers to this subnet when creating internal load balancers. Because of the invalid subnet reference, kube-controller-manager fails to find the subnet, and thus fails to provision internal load balancers. This commit fixes the reference and thus fixes internal ingresscontrollers on Azure for new installations. This commit does not fix existing invalid cloudprovider configmaps. This is a fix of https://bugzilla.redhat.com/show_bug.cgi?id=1763727 only for new installations.
openshift-ci-robot
added
the
size/XS
jhixson74
approved these changes
Oct 23, 2019
Member
|
/lgtm |
Contributor
|
/test e2e-azure |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, ironcladlou, jhixson74 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
|
/retest |
1 similar comment
Contributor
|
/retest |
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Nov 6, 2019
…rker-subnet Catch this example up with cfa5d59 (Fix Azure cloud provider subnet reference, 2019-10-23, openshift#2556). This is just a dummy value for the unit tests, but it's nice to be internally consistent anyway ;).
jhixson74
pushed a commit
to jhixson74/installer
that referenced
this pull request
Dec 6, 2019
…rker-subnet Catch this example up with cfa5d59 (Fix Azure cloud provider subnet reference, 2019-10-23, openshift#2556). This is just a dummy value for the unit tests, but it's nice to be internally consistent anyway ;).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Azure, the installer is configuring the cloud provider with a subnet using a
-node-subnetsuffix. This is incorrect, as the actual subnet created for Azurehas a
-worker-subnetsuffix. The cloud provider refers to this subnet whencreating internal load balancers. Because of the invalid subnet reference,
kube-controller-manager fails to find the subnet, and thus fails to provision
internal load balancers. This commit fixes the reference and thus fixes internal
ingresscontrollers on Azure for new installations.
This commit does not fix existing invalid cloudprovider configmaps.
This is a fix of https://bugzilla.redhat.com/show_bug.cgi?id=1763727 only for
new installations.