Skip to content

fix: Download jenkins-plugin-manager JAR in verify script#2346

Open
kunalmemane wants to merge 1 commit intoopenshift:masterfrom
kunalmemane:update-verify-script
Open

fix: Download jenkins-plugin-manager JAR in verify script#2346
kunalmemane wants to merge 1 commit intoopenshift:masterfrom
kunalmemane:update-verify-script

Conversation

@kunalmemane
Copy link
Copy Markdown
Member

@kunalmemane kunalmemane commented Apr 6, 2026

verify.sh assumed jenkins-plugin-manager.jar existed locally but it was never included in the repo. The script now downloads the JAR from GitHub releases on first run, uses a temp plugin directory so it works outside the container image, and gitignores the downloaded binary.

tool - https://github.com/jenkinsci/plugin-installation-manager-tool

verify.sh assumed jenkins-plugin-manager.jar existed locally but it was
never included in the repo. The script now downloads the JAR from
GitHub releases on first run, uses a temp plugin directory so it works
outside the container image, and gitignores the downloaded binary.

Signed-off-by: Kunal Memane <kmemane@redhat.com>
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 6, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2026
@kunalmemane kunalmemane marked this pull request as ready for review April 6, 2026 06:06
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2026
@openshift-ci openshift-ci Bot requested review from avinal and sayan-biswas April 6, 2026 06:06
@kunalmemane
Copy link
Copy Markdown
Member Author

/test e2e-aws

3 similar comments
@kunalmemane
Copy link
Copy Markdown
Member Author

/test e2e-aws

@kunalmemane
Copy link
Copy Markdown
Member Author

/test e2e-aws

@kunalmemane
Copy link
Copy Markdown
Member Author

/test e2e-aws

@kunalmemane
Copy link
Copy Markdown
Member Author

/retest

@kunalmemane
Copy link
Copy Markdown
Member Author

/test e2e-aws

1 similar comment
@kunalmemane
Copy link
Copy Markdown
Member Author

/test e2e-aws

@prdhamdh
Copy link
Copy Markdown
Contributor

/lgtm
/approve
/label backport-risk-assessed
/label px-approved
/label docs-approved
/label qe-approved

@openshift-ci openshift-ci Bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Apr 24, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kunalmemane, prdhamdh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2026
@prdhamdh
Copy link
Copy Markdown
Contributor

/verified by e2e-aws-jenkins-sync-plugin

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@prdhamdh: This PR has been marked as verified by e2e-aws-jenkins-sync-plugin.

Details

In response to this:

/verified by e2e-aws-jenkins-sync-plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 24, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 187bc2c and 2 for PR HEAD 4bc97e9 in total

@kunalmemane
Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@kunalmemane
Copy link
Copy Markdown
Member Author

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 27, 2026

@kunalmemane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-jenkins-client-plugin 4bc97e9 link true /test e2e-aws-jenkins-client-plugin
ci/prow/e2e-aws 4bc97e9 link true /test e2e-aws
ci/prow/images 4bc97e9 link true /test images
ci/prow/e2e-aws-jenkins-sync-plugin 4bc97e9 link true /test e2e-aws-jenkins-sync-plugin

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants