Skip to content

Fix build on other Linux architectures#12

Closed
yselkowitz wants to merge 1 commit intoopenshift:masterfrom
multi-arch:master
Closed

Fix build on other Linux architectures#12
yselkowitz wants to merge 1 commit intoopenshift:masterfrom
multi-arch:master

Conversation

@yselkowitz
Copy link
Copy Markdown

Merge from upstream:

kubernetes-retired#1039
kubernetes-retired@6370d75

We will need this in 4.2 and later branches.

v2: rename the OS variables to reflect os/arch pairing
@openshift-ci-robot
Copy link
Copy Markdown

Hi @yselkowitz. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 19, 2019
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yselkowitz
To complete the pull request process, please assign abhat
You can assign the PR to them by writing /assign @abhat in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sohankunkerkar
Copy link
Copy Markdown
Member

/retest

@sohankunkerkar
Copy link
Copy Markdown
Member

@yselkowitz Thanks for filing this PR. It looks like we're planning to fast-forward our master branch to upstream v0.1.0-rc4 release which includes your change as well so I'm closing this PR to avoid any duplicate work.

@yselkowitz
Copy link
Copy Markdown
Author

@sohankunkerkar will 4.2 and 4.3 branches also be fast-forwarded? We need those fixed as well.

@abhat
Copy link
Copy Markdown

abhat commented Jul 30, 2019

@yselkowitz yes, those will get forwarded from the downstream master.

@abhat abhat closed this Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants