NO-JIRA: Create Vault Secret for fake Vault setup

[ardaguclu]

This PR configures fake Vault plugin to create the referenced secret. Otherwise, #2212 degrades the cluster.

Summary by CodeRabbit

• Tests
  • Enhanced test infrastructure for encryption provider configuration with improved constant usage and reduced hardcoding in vault-based encryption setup.

[openshift-ci-robot]

@ardaguclu: This pull request explicitly references no jira issue.

Details

In response to this:

This PR configures fake Vault plugin to create the referenced secret. Otherwise, #2212 degrades the cluster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1fb4d535-74bc-4983-b9fb-01a2d5aa8bdc

📥 Commits

Reviewing files that changed from the base of the PR and between 83d6ad9 and 216bf62.

📒 Files selected for processing (1)

• test/library/encryption/kms/vault.go

---

Walkthrough

This PR refactors the fake Vault KMS test encryption provider in test/library/encryption/kms/vault.go by introducing a new exported DefaultFakeVaultEncryptionProvider that bundles the KMS config with AppRole secret setup, and updates the underlying config to use a centralized constant for the AppRole secret name instead of a hardcoded string.

Changes

Vault KMS test helpers

Layer / File(s)	Summary
Refactored Vault encryption provider and AppRole secret setup test/library/encryption/kms/vault.go	DefaultFakeVaultEncryptionProvider is introduced as a new exported provider pairing DefaultFakeKMSPluginConfig with ensureDefaultVaultAppRoleSecret. The config is updated to reference defaultVaultAppRoleSecretName constant for the AppRole secret instead of using a hardcoded literal string.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

• openshift/library-go#2225: Both PRs modify test/library/encryption/kms/vault.go to wire an AppRole-secret setup helper into the exported Vault KMS encryption provider setup, along with related AppRole secret-name references.

Suggested reviewers

• dgrisonnet

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding a new Vault secret creation mechanism for the fake Vault setup to prevent degradation from a prior PR.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The modified file contains no Ginkgo test declarations (It, Describe, Context, When), only configuration variables and helper functions. The check is not applicable to this PR.
Test Structure And Quality	✅ Passed	The PR modifies a test helper library module, not Ginkgo test code. The custom check is for Ginkgo test structure (It blocks, BeforeEach, etc.) and is not applicable.
Microshift Test Compatibility	✅ Passed	The PR adds test helper variables and updates configuration in a test library file, not new Ginkgo e2e tests. No It(), Describe(), Context(), or When() test declarations are present.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR does not add any Ginkgo e2e tests. Changes are test helper library code in test/library/encryption/kms/vault.go, adding fixtures and configuration utilities only.
Topology-Aware Scheduling Compatibility	✅ Passed	Test library code only—no deployment manifests, operator code, or scheduling constraints are introduced or modified.
Ote Binary Stdout Contract	✅ Passed	All t.Logf() calls are inside test helper functions intercepted by testing framework. No module-level stdout writes, init() functions, or process-level entry points violating OTE stdout contract.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR modifies vault.go, a helper/utility library file. No new Ginkgo e2e tests (It, Describe, Context, When) are added; only configuration variables and utility functions are exported.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[p0lyn0mial]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• test/library/encryption/OWNERS [p0lyn0mial]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ardaguclu]

/hold
first we merge #2221

[ardaguclu]

flake
/retest

[ardaguclu]

/hold cancel

[ardaguclu]

/retest

[openshift-ci]

@ardaguclu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.