Fix nginx crash in console plugin with ubi9-minimal base image#2
Merged
Conversation
Add PID file path, temp directory paths, and IPv6 listen directive to the nginx config generated by the console reconciler. Without these, nginx fails to start with "open() /run/nginx.pid failed (Permission denied)" when the console image uses ubi9-minimal + microdnf nginx instead of the pre-configured ubi9/nginx-120 image. Found while testing openshift/lightspeed-agentic-console#2 (Konflux hermetic build migration to ubi9-minimal). Aligns the agentic operator's nginx config with the base operator's version in lightspeed-operator/internal/controller/console/assets.go. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
merged openshift/lightspeed-agentic-console#2, so merging this one as well. |
xrajesh
pushed a commit
to xrajesh/lightspeed-agentic-operator
that referenced
this pull request
May 10, 2026
…1, #13-17, #19-22, #29, #32) - openshift#1: Change status.attempts from *int32 to int32 with min=1/max=int32 validation - openshift#2: Move maxAttempts from ProposalSpec to ApprovalPolicy (admin ceiling) and ExecutionApproval (user choice); fix semantics so N = N total attempts - openshift#3: Remove spec.revision, use metadata.generation for revision signaling - openshift#4: Make ProposalStep.tools non-pointer with omitzero, add MinProperties=1 - #8-11: Make outcome/result/conditionOutcome required; SandboxInfo fields required - #13: Add CEL singleton rule (metadata.name == "cluster") on ApprovalPolicy - #14: Use listType=map+listMapKey=name on ApprovalPolicy stages - #15: Remove defaultOption from ApprovalPolicy (operator defaults to option 0) - #16-17: Add omitempty to name/approval, document allowed values - #19: Replace denied bool with decision enum (Approved|Denied) + CEL immutability - #20: Make ProposalApproval spec required - #21: Use listType=map+listMapKey=type on ProposalApproval stages - #22: Make estimatedImpact required on RemediationOption - #29: Remove components from ExecutionResult and VerificationResult (copy-paste error) - #32: Add MinProperties=1 to ToolsSpec Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pid, temp directory paths, and IPv6 listen directive to the nginx config generated by the console reconcileropen() "/run/nginx.pid" failed (Permission denied)when the console image usesubi9-minimal+microdnf install nginxinstead of the pre-configuredubi9/nginx-120imagelightspeed-operator/internal/controller/console/assets.goContext
Found while testing openshift/lightspeed-agentic-console#2 (Konflux hermetic build migration to ubi9-minimal). The
ubi9/nginx-120image had built-in non-root-friendly defaults; raw nginx from microdnf does not.Test plan
/lightspeed/proposals🤖 Generated with Claude Code