Skip to content

Remove unused exports related to OlsToolUIs#1740

Open
kyoto wants to merge 1 commit intoopenshift:mainfrom
kyoto:remove-exports-for-OlsToolUIs
Open

Remove unused exports related to OlsToolUIs#1740
kyoto wants to merge 1 commit intoopenshift:mainfrom
kyoto:remove-exports-for-OlsToolUIs

Conversation

@kyoto
Copy link
Copy Markdown
Member

@kyoto kyoto commented Apr 3, 2026

No description provided.

@kyoto kyoto added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a7f09872-173a-40b2-aefc-f4eab4da6ca9

📥 Commits

Reviewing files that changed from the base of the PR and between 65db72a and 83bafcf.

📒 Files selected for processing (2)
  • src/components/OlsToolUIs.tsx
  • src/hooks/useToolUIMapping.ts

Walkthrough

These changes reduce public export surface area by converting previously exported named constants into module-scoped constants. OlsToolUI and OlsToolUIs lose named export status while OlsToolUIs retains default export. useToolUIExtensions becomes module-private. Exported APIs remain functionally unchanged.

Changes

Cohort / File(s) Summary
Export visibility reduction
src/components/OlsToolUIs.tsx, src/hooks/useToolUIMapping.ts
Removed named exports from internal helper components and hooks by converting export const declarations to module-scoped const. OlsToolUIs and useToolUIMapping remain publicly available as default/named exports respectively.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from joshuawilson and xrajesh April 3, 2026 06:48
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyoto
Copy link
Copy Markdown
Member Author

kyoto commented Apr 3, 2026

/cherry-pick pattern-fly-5

@openshift-cherrypick-robot
Copy link
Copy Markdown

@kyoto: once the present PR merges, I will cherry-pick it on top of pattern-fly-5 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick pattern-fly-5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants