[release-4.19] OLS-2925: Fix revert not clearing edit icon from attachment label

[openshift-cherrypick-robot]

This is an automated cherry-pick of #1861

/assign kyoto

Summary by CodeRabbit

• Bug Fixes

  • Fixed attachment revert functionality to correctly restore and include the original attachment value when reverting edits, ensuring proper attachment references are maintained during revert operations.

• Tests

  • Added test coverage for attachment revert behavior to validate that reverting edited attachments correctly clears modified state and restores original information.

[openshift-ci-robot]

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: OLS-2925

Details

In response to this:

This is an automated cherry-pick of #1861

/assign kyoto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 980a6b38-5189-42e8-a1fe-e1199deab6e1

📥 Commits

Reviewing files that changed from the base of the PR and between a4a10fa and 9d188b9.

📒 Files selected for processing (2)

• src/components/AttachmentModal.tsx
• unit-tests/redux-reducers.test.ts

---

📝 Walkthrough

Walkthrough

The pull request updates the attachment revert functionality to explicitly pass the resolved original value to the attachment update function instead of undefined, and adds a test case validating this revert behavior.

Changes

Cohort / File(s)	Summary
Attachment Revert Logic src/components/AttachmentModal.tsx	Updated onRevert to supply the resolved original value to attachmentSet(...) instead of undefined, ensuring reverted attachments include an explicit reference value.
Revert Behavior Validation unit-tests/redux-reducers.test.ts	Added unit test for the AttachmentSet revert behavior, verifying that when an edited attachment's value is restored to match its original value, the changed state is properly cleared.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A whisker of change, a fix most neat,
Reverting attachments, now complete!
Original values, no longer lost,
With tests that verify, at any cost.
Hoppy coding, bug-free and bright!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly addresses the main change: fixing the revert functionality to clear the edit icon from attachment labels by passing the resolved original value to attachmentSet.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[kyoto]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kyoto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references OLS-2925 which is a valid jira issue.

Details

In response to this:

This is an automated cherry-pick of #1861

/assign kyoto

Summary by CodeRabbit

• Bug Fixes

• Fixed attachment revert functionality to correctly restore and include the original attachment value when reverting edits, ensuring proper attachment references are maintained during revert operations.

• Tests

• Added test coverage for attachment revert behavior to validate that reverting edited attachments correctly clears modified state and restores original information.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.