PF5: Enable TypeScript noImplicitAny option & fix types as necessary

[kyoto]

Manual cherry pick of #1971

Summary by CodeRabbit

• Chores

  • Added missing TypeScript type definitions and tightened compiler settings to enforce stricter typing.
  • Improved type annotations across UI components and hooks for more robust behavior.

• Bug Fixes

  • Adjusted alerting rule ID generation, which changes produced IDs for the same inputs (may affect existing references).

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a2e83cf7-9bbe-4e02-b97b-cbdd83556c34

📥 Commits

Reviewing files that changed from the base of the PR and between e17d1bd and a195f70.

⛔ Files ignored due to path filters (1)

• package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (9)

• package.json
• src/components/AttachLogModal.tsx
• src/components/AttachmentModal.tsx
• src/components/AttachmentsSizeAlert.tsx
• src/components/Prompt.tsx
• src/hooks/usePopover.ts
• src/redux-reducers.ts
• src/validation.ts
• tsconfig.json

💤 Files with no reviewable changes (1)

• tsconfig.json

✅ Files skipped from review due to trivial changes (1)

• src/redux-reducers.ts

---

📝 Walkthrough

Walkthrough

Tightens TypeScript typing across components, hooks, and reducers, adds @types dependencies, removes the explicit noImplicitAny override in tsconfig, and changes alertingRuleID to hash only the key string (removing the previous salt argument).

Changes

TypeScript Strict Mode & Type Annotations

Layer / File(s)	Summary
Dependencies and tsconfig package.json, tsconfig.json	Adds @types entries for js-yaml, lodash, murmurhash-js, react-modal, react-redux. Removes explicit noImplicitAny: false so strict: true governs implicit-any behavior.
AttachLogModal selector & container typing src/components/AttachLogModal.tsx	Imports Selector, switches Job and VM label selectors to matchLabels (job-name, vm.kubevirt.io/name), and types container name extraction before sorting.
Editor mount workaround & attachments sizing src/components/AttachmentModal.tsx, src/components/AttachmentsSizeAlert.tsx	Adds EditorDidMount typing and casts monaco.editor assignment for the onDidChangeMarkers workaround; types Attachment in the total-chars reduce callback.
Prompt: Prometheus/Alertmanager typing and YAML validation src/components/Prompt.tsx	Adds typed Prometheus shapes (PrometheusAlert, PrometheusRule, PrometheusRulesResponse, Silence), tightens YAML upload parsing by treating loadYAML possibly null, and types attachments when pushing chat history.
usePopover return type & reducer entry typing src/hooks/usePopover.ts, src/redux-reducers.ts	Changes usePopover to explicitly return null; adds ImmutableMap<string, unknown> typing to findIndex predicates in two reducer cases.
Validation hash computation change src/validation.ts	alertingRuleID now calls murmur3 with only the constructed key (removes 'monitoring-salt' second argument), altering produced IDs.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• openshift/lightspeed-console#1971: Makes overlapping TypeScript typing and tsconfig/noImplicitAny changes across the same files.
• openshift/lightspeed-console#1960: Introduced alertingRuleID murmur3 hashing with the 'monitoring-salt' argument that this PR modifies.
• openshift/lightspeed-console#1955: Related changes to alerting-rule ID hashing affecting how rules are identified.

Suggested reviewers

• syedriko
• xrajesh

"🐰 I tightened types with a careful hop,
Each selector now matches without a stop,
The editor listens, attachments counted true,
One hash lost its salt — the output is new,
Hooray! — a tidy patch from this rabbit to you."

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main objective of the PR: enabling TypeScript's noImplicitAny option and fixing types throughout the codebase.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kyoto]

/retest

[openshift-ci]

New changes are detected. LGTM label has been removed.