Skip to content

4.19: Upgrade webpack-dev-server to 5.2.5 and ws to 8.21.0#2124

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:release-4.19from
kyoto:4.19-webpack-dev-server-5.2.5
Jun 23, 2026
Merged

4.19: Upgrade webpack-dev-server to 5.2.5 and ws to 8.21.0#2124
openshift-merge-bot[bot] merged 2 commits into
openshift:release-4.19from
kyoto:4.19-webpack-dev-server-5.2.5

Conversation

@kyoto

@kyoto kyoto commented Jun 23, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated development dependencies to newer versions, including build tools and packages.

@kyoto kyoto added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 23, 2026
@openshift-ci openshift-ci Bot requested review from syedriko and xrajesh June 23, 2026 04:35
@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 944111d6-b549-4f16-91f1-9d54105a5862

📥 Commits

Reviewing files that changed from the base of the PR and between 21942b7 and b53eb9f.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json

📝 Walkthrough

Walkthrough

package.json is updated to bump webpack-dev-server from 5.2.4 to 5.2.5 in devDependencies and to add an explicit ws override at 8.21.0 in the overrides block. No other dependencies or configurations are changed.

Changes

Dependency Update

Layer / File(s) Summary
webpack-dev-server bump and ws override
package.json
webpack-dev-server is bumped from 5.2.4 to 5.2.5 in devDependencies, and ws at 8.21.0 is added to the overrides section alongside the existing react/react-dom overrides.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 A hop and a skip, the versions align,
webpack-dev-server bumped down the line.
A ws override tucked in with care,
Packages refreshed with a bunny's flair!
All is well in the dependency den~ 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately and specifically describes the main changes: upgrading webpack-dev-server to 5.2.5 and adding a ws override to 8.21.0, which directly matches the package.json modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot openshift-merge-bot Bot merged commit 3ff25a2 into openshift:release-4.19 Jun 23, 2026
5 checks passed
@kyoto kyoto deleted the 4.19-webpack-dev-server-5.2.5 branch June 23, 2026 05:35
@kyoto

kyoto commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

/cherry-pick main

@openshift-cherrypick-robot

Copy link
Copy Markdown

@kyoto: #2124 failed to apply on top of branch "main":

Applying: Upgrade webpack-dev-server to 5.2.5
Applying: Upgrade ws to 8.21.0
Using index info to reconstruct a base tree...
M	package-lock.json
M	package.json
Falling back to patching base and 3-way merge...
Auto-merging package-lock.json
Auto-merging package.json
CONFLICT (content): Merge conflict in package.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0002 Upgrade ws to 8.21.0

Details

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants