Skip to content

Set correct service ID for RHOSO Lightspeed#1213

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
lpiwowar:lpiwowar/set-system-id
Jan 15, 2026
Merged

Set correct service ID for RHOSO Lightspeed#1213
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
lpiwowar:lpiwowar/set-system-id

Conversation

@lpiwowar
Copy link
Contributor

@lpiwowar lpiwowar commented Jan 13, 2026

Description

Detect RHOSO Lightspeed deployments and use the correct service ID for feedback and transcript gathering.

When OLSConfig contains the openstack.org/lightspeed-owner-id label, the service ID is set to rhos-lightspeed instead of the default ols. This ensures proper identification when deployed via the openstack-lightspeed/operator.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  1. Run openshift/lightspeed-operator with this change.
  2. Create OLSConfig with the openstack.org/lightspeed-owner-id label present.
  3. Ask a simple question through the OpenShift console.
  4. Check in the logs of the data exporter whether it sent the transcript.
  5. Check whether the transcript landed in the S3 bucket with the correct service ID set (thanks to @onmete)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 13, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Detect RHOSO Lightspeed deployments and use the correct service ID for
feedback and transcript gathering.

When OLSConfig contains the "openstack.org/lightspeed-owner-id" label,
the service ID is set to "rhos-lightspeed" instead of the default "ols".
This ensures proper identification when deployed via
the openstack-lightspeed/operator.
@lpiwowar lpiwowar force-pushed the lpiwowar/set-system-id branch from 19041a7 to 5769fc5 Compare January 14, 2026 11:53
@lpiwowar
Copy link
Contributor Author

/test all

@lpiwowar lpiwowar marked this pull request as ready for review January 14, 2026 13:26
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 14, 2026

@lpiwowar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@umago
Copy link

umago commented Jan 14, 2026

Thanks @lpiwowar! LGTM

@blublinsky
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2026
@xrajesh
Copy link
Contributor

xrajesh commented Jan 15, 2026

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jan 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrajesh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 1c4ea31 into openshift:main Jan 15, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants