Create mcp approval support configuration#1288
Create mcp approval support configuration#1288blublinsky wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
| // 'tool_annotations' - approval based on per-tool annotations | ||
| // +kubebuilder:default=never | ||
| // +operator-sdk:csv:customresourcedefinitions:type=spec,displayName="Approval Type" | ||
| ApprovalType ApprovalType `json:"approvalType,omitempty"` |
There was a problem hiding this comment.
What options do we want to present to the users in CR? Would just enabling/disabling be enough?
When enabled, only read-only tools will not raise for approval - every other tool will.
This ApprovalType also allows raising for read-only tools (via always).
There was a problem hiding this comment.
- You can skip this configuratio
- You can use never as approval type
Both will bypass approval logic
blublinsky
force-pushed
the
approval-configuration
branch
from
40895da to
55a1e92
Compare
|
@blublinsky: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
blublinsky
force-pushed
the
approval-configuration
branch
from
55a1e92 to
cb63739
Compare
2 participants
Description
Type of change
Related Tickets & Documents
OLS-2658
OLS-2658
Checklist before requesting a review
Testing