Updated Vertex credentials#2918
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| @pytest.fixture | ||
| def anthropic_provider_config(tmpdir): | ||
| """Return provider configuration for Vertex Anthropic.""" | ||
| credentials_json = generate_service_account_json_string() |
There was a problem hiding this comment.
add a case for authorized_user case too ? @blublinsky
39eefb8 to
311e0da
Compare
|
@blublinsky: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Summary
Vertex credential JSON: Supports type: service_account (existing) and type: authorized_user (refresh token + client id/secret, optional token_uri / quota_project_id). Shared helper load_vertex_credentials in ols/src/llms/providers/utils.py validates JSON shape, requires a non-empty type, and applies VERTEX_AI_OAUTH_SCOPES for Vertex.
Single module: GoogleVertexAnthropic lives in google_vertex.py next to GoogleVertex; google_vertex_anthropic.py removed. Registry/tests import both from google_vertex.
Tests: Vertex Gemini + Anthropic coverage consolidated in test_google_vertex.py; test_google_vertex_anthropic.py removed. Provider registry test imports updated.
Docs: docs/ai/providers.md and .ai/spec/how/* updated for module layout and credential file shapes.
Tooling: Bandit exclude_dirs extended with .venv and konflux-artifacts so local scans stay scoped (optional to mention if you want a minimal PR—split if reviewers prefer).
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing