Skip to content

Updated Vertex credentials#2918

Open
blublinsky wants to merge 1 commit intoopenshift:mainfrom
blublinsky:vertex-creds
Open

Updated Vertex credentials#2918
blublinsky wants to merge 1 commit intoopenshift:mainfrom
blublinsky:vertex-creds

Conversation

@blublinsky
Copy link
Copy Markdown
Contributor

Description

Summary
Vertex credential JSON: Supports type: service_account (existing) and type: authorized_user (refresh token + client id/secret, optional token_uri / quota_project_id). Shared helper load_vertex_credentials in ols/src/llms/providers/utils.py validates JSON shape, requires a non-empty type, and applies VERTEX_AI_OAUTH_SCOPES for Vertex.
Single module: GoogleVertexAnthropic lives in google_vertex.py next to GoogleVertex; google_vertex_anthropic.py removed. Registry/tests import both from google_vertex.
Tests: Vertex Gemini + Anthropic coverage consolidated in test_google_vertex.py; test_google_vertex_anthropic.py removed. Provider registry test imports updated.
Docs: docs/ai/providers.md and .ai/spec/how/* updated for module layout and credential file shapes.
Tooling: Bandit exclude_dirs extended with .venv and konflux-artifacts so local scans stay scoped (optional to mention if you want a minimal PR—split if reviewers prefer).

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@openshift-ci openshift-ci Bot requested review from tisnik and xrajesh May 5, 2026 15:48
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xrajesh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pytest.fixture
def anthropic_provider_config(tmpdir):
"""Return provider configuration for Vertex Anthropic."""
credentials_json = generate_service_account_json_string()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a case for authorized_user case too ? @blublinsky

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@blublinsky blublinsky force-pushed the vertex-creds branch 4 times, most recently from 39eefb8 to 311e0da Compare May 7, 2026 09:46
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 7, 2026

@blublinsky: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants