Skip to content

OCPBUGS-17586: Get DPLL clock ID from card DSN#179

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
vitus133:dpll-clock-id
Aug 15, 2023
Merged

OCPBUGS-17586: Get DPLL clock ID from card DSN#179
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
vitus133:dpll-clock-id

Conversation

@vitus133
Copy link
Copy Markdown
Contributor

@vitus133 vitus133 commented Aug 7, 2023

This commit changes the way T-GM clock id is attained
to be consistent with what Intel ice driver does.

/cc @aneeshkp @jzding @josephdrichard

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2023
josephdrichard
josephdrichard reviewed Aug 9, 2023
View reviewed changes
Comment thread addons/intel/e810.go Outdated
josephdrichard
josephdrichard reviewed Aug 9, 2023
View reviewed changes
Comment thread pkg/daemon/daemon.go Outdated
josephdrichard
josephdrichard reviewed Aug 9, 2023
View reviewed changes
Comment thread addons/intel/e810.go Outdated
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2023
@vitus133 vitus133 force-pushed the dpll-clock-id branch 2 times, most recently from 0f9b49d to 05591b3 Compare August 10, 2023 13:18
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2023
@vitus133
Get DPLL clock ID from card DSN
75ffb3d 
Signed-off-by: Vitaly Grinberg <vgrinber@redhat.com>
@vitus133
Copy link
Copy Markdown
Contributor Author

vitus133 commented Aug 10, 2023

/override ci/prow/e2e-aws
/override ci/prow/images

@vitus133 vitus133 changed the title Get DPLL clock ID from card DSN OCPBUGS-17586: Get DPLL clock ID from card DSN Aug 10, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 10, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 10, 2023

@vitus133: This pull request references Jira Issue OCPBUGS-17586, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This commit changes the way T-GM clock id is attained
to be consistent with what Intel ice driver does.

/cc @aneeshkp @jzding @josephdrichard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 10, 2023

@vitus133: Overrode contexts on behalf of vitus133: ci/prow/e2e-aws, ci/prow/images

Details

In response to this:

/override ci/prow/e2e-aws
/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jzding
jzding approved these changes Aug 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jzding jzding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jzding, vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vitus133
Copy link
Copy Markdown
Contributor Author

vitus133 commented Aug 15, 2023

/override ci/prow/images
/override ci/prow/e2e-aws

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 15, 2023

@vitus133: Overrode contexts on behalf of vitus133: ci/prow/e2e-aws, ci/prow/images

Details

In response to this:

/override ci/prow/images
/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 15, 2023

@vitus133: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit f1d2ccc into openshift:master Aug 15, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 15, 2023

@vitus133: Jira Issue OCPBUGS-17586: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17586 has been moved to the MODIFIED state.

Details

In response to this:

This commit changes the way T-GM clock id is attained
to be consistent with what Intel ice driver does.

/cc @aneeshkp @jzding @josephdrichard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

josephdrichard pushed a commit to josephdrichard/linuxptp-daemon that referenced this pull request Mar 20, 2026
@nocturnalastro
Merge pull request openshift#179 from jzding/clockclass-reconnect
9053cfa 
Fix clock class metrics lost after cloud-event-proxy restart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aneeshkp aneeshkp Awaiting requested review from aneeshkp

2 more reviewers

@josephdrichard josephdrichard josephdrichard left review comments

@jzding jzding jzding approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jzding jzding

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vitus133 @openshift-ci-robot @jzding @josephdrichard @openshift-merge-robot