Skip to content

OCPBUGS-17426: discard invalid dpll notifications#180

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
vitus133:dpll-discard-invalid-ntf
Aug 9, 2023
Merged

OCPBUGS-17426: discard invalid dpll notifications#180
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
vitus133:dpll-discard-invalid-ntf

Conversation

@vitus133
Copy link
Copy Markdown
Contributor

@vitus133 vitus133 commented Aug 8, 2023

E810 DPLL driver may send incomplete DPLL notifications where, for example, LockStatus is omitted.
When they are handled, the daemon reports freerun mode, while in fact the system is in holdover.
Invalid notifications should be discarded.
/cc @aneeshkp @jzding @josephdrichard

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 8, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 8, 2023

@vitus133: This pull request references Jira Issue OCPBUGS-17426, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

E810 DPLL driver may send incomplete DPLL notifications where, for example, LockStatus is omitted.
When they are handled, the daemon reports freerun mode, while in fact the system is in holdover.
Invalid notifications should be discarded.
/cc @aneeshkp @jzding @josephdrichard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2023
@vitus133
Copy link
Copy Markdown
Contributor Author

vitus133 commented Aug 8, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 8, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 8, 2023

@vitus133: This pull request references Jira Issue OCPBUGS-17426, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vitus133 vitus133 force-pushed the dpll-discard-invalid-ntf branch from 9ca55c3 to f1ab54f Compare August 8, 2023 07:52
aneeshkp
aneeshkp approved these changes Aug 9, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@aneeshkp aneeshkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2023
@vitus133
Copy link
Copy Markdown
Contributor Author

vitus133 commented Aug 9, 2023

/override ci/prow/e2e-aws
/override ci/prow/images

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 9, 2023

@vitus133: Overrode contexts on behalf of vitus133: ci/prow/e2e-aws, ci/prow/images

Details

In response to this:

/override ci/prow/e2e-aws
/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vitus133
discard invalid dpll notifications
b593865 
Signed-off-by: Vitaly Grinberg <vgrinber@redhat.com>
@vitus133 vitus133 force-pushed the dpll-discard-invalid-ntf branch from f1ab54f to b593865 Compare August 9, 2023 12:26
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2023
@aneeshkp
Copy link
Copy Markdown
Contributor

aneeshkp commented Aug 9, 2023

/lgtm

@aneeshkp
Copy link
Copy Markdown
Contributor

aneeshkp commented Aug 9, 2023

/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 9, 2023

/retest-required

Remaining retests: 0 against base HEAD c03d237 and 2 for PR HEAD b593865 in total

@jzding
Copy link
Copy Markdown
Contributor

jzding commented Aug 9, 2023

/override ci/prow/e2e-aws ci/prow/images

jzding
jzding approved these changes Aug 9, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jzding jzding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vitus133
Copy link
Copy Markdown
Contributor Author

vitus133 commented Aug 9, 2023

/override ci/prow/e2e-aws
/override ci/prow/images

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 9, 2023

@jzding: jzding unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight.

Details

In response to this:

/override ci/prow/e2e-aws ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, jzding, vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 9, 2023

@vitus133: Overrode contexts on behalf of vitus133: ci/prow/e2e-aws, ci/prow/images

Details

In response to this:

/override ci/prow/e2e-aws
/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 9, 2023

@vitus133: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 6625437 into openshift:master Aug 9, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 9, 2023

@vitus133: Jira Issue OCPBUGS-17426: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17426 has been moved to the MODIFIED state.

Details

In response to this:

E810 DPLL driver may send incomplete DPLL notifications where, for example, LockStatus is omitted.
When they are handled, the daemon reports freerun mode, while in fact the system is in holdover.
Invalid notifications should be discarded.
/cc @aneeshkp @jzding @josephdrichard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

josephdrichard added a commit to josephdrichard/linuxptp-daemon that referenced this pull request Mar 20, 2026
@josephdrichard
Merge pull request openshift#180 from k8snetworkplumbingwg/fix_gm_sta…
413c8f9 
…te_on_gnss_loss

Fix reporting of GM state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josephdrichard josephdrichard Awaiting requested review from josephdrichard

2 more reviewers

@aneeshkp aneeshkp aneeshkp approved these changes

@jzding jzding jzding approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aneeshkp aneeshkp

@jzding jzding

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vitus133 @openshift-ci-robot @aneeshkp @jzding @openshift-merge-robot