Skip to content

OCPBUGS-85566: Allow non-GNSS leap second sources#600

Open
lack wants to merge 1 commit into
openshift:release-4.20from
lack:non_gnss_leapseconds_4.20
Open

OCPBUGS-85566: Allow non-GNSS leap second sources#600
lack wants to merge 1 commit into
openshift:release-4.20from
lack:non_gnss_leapseconds_4.20

Conversation

@lack
Copy link
Copy Markdown
Member

@lack lack commented May 13, 2026

Add API to enable / disable leap second sources.
By default (and if leapSources is omitted) all satellite
sources are enabled. To disable sources, specify them
under the plugin gnss->leapSources section:
e825:
devices:
- eno8703
gnss:
disabled: false
leapSources:
navic: false

Signed-off-by: Vitaly Grinberg vgrinber@redhat.com

Add API to enable / disable leap second sources.
By default (and if leapSources is omitted) all satellite
sources are enabled. To disable sources, specify them
under the plugin gnss->leapSources section:
    e825:
      devices:
        - eno8703
      gnss:
        disabled: false
        leapSources:
          navic: false

Signed-off-by: Vitaly Grinberg <vgrinber@redhat.com>
@lack
Copy link
Copy Markdown
Member Author

lack commented May 13, 2026

/jira cherry-pick OCPBUGS-80924

@openshift-ci openshift-ci Bot requested review from aneeshkp and nocturnalastro May 13, 2026 16:11
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lack
Once this PR has been reviewed and has the lgtm label, please assign jzding for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@lack: Jira Issue OCPBUGS-80924 has been cloned as Jira Issue OCPBUGS-85566. Will retitle bug to link to clone.

WARNING: Unexpected sprint field type []interface {} on source issue. Please update sprint manually on clone.

/retitle OCPBUGS-85566: Allow non-GNSS leap second sources

Details

In response to this:

/jira cherry-pick OCPBUGS-80924

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title Allow non-GNSS leap second sources OCPBUGS-85566: Allow non-GNSS leap second sources May 13, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 13, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@lack: This pull request references Jira Issue OCPBUGS-85566, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Add API to enable / disable leap second sources.
By default (and if leapSources is omitted) all satellite
sources are enabled. To disable sources, specify them
under the plugin gnss->leapSources section:
e825:
devices:
- eno8703
gnss:
disabled: false
leapSources:
navic: false

Signed-off-by: Vitaly Grinberg vgrinber@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lack
Copy link
Copy Markdown
Member Author

lack commented May 13, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 13, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@lack: This pull request references Jira Issue OCPBUGS-85566, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-80924 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-80924 targets the "4.21.z" version, which is one of the valid target versions: 4.21.0, 4.21.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (bblock@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lack
Copy link
Copy Markdown
Member Author

lack commented May 13, 2026

/label backport-risk-assessed

@lack
Copy link
Copy Markdown
Member Author

lack commented May 13, 2026

/verified later @Bonnie-Block

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 13, 2026
@openshift-ci-robot openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels May 13, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@lack: This PR has been marked to be verified later by @bonnie-block.

Details

In response to this:

/verified later @Bonnie-Block

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 13, 2026

@lack: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Development

Successfully merging this pull request may close these issues.