Bug 2024731:Remove ethtool status check loop

[aneeshkp]

runDeviceStatusUpdate was called every minute to check PTP capabilities of the nic and update the nodePtpDevice CR status.
This was causing CPU usage to spike every minute.
The change will remove the loop and call it only once and update the CR with the status as shown below.

 status:
    devices:
    - name: eno1
    - name: eno2
    - name: ens5f0
    - name: ens5f1
    - name: ens7f0
    - name: ens7f1

Signed-off-by: Aneesh Puttur aneeshputtur@gmail.com

[openshift-ci]

@aneeshkp: This pull request references Bugzilla bug 2024731, which is invalid:

• expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2024731: Remove ethtool status check loop

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aneeshkp]

/bugzilla refresh

[openshift-ci]

@aneeshkp: This pull request references Bugzilla bug 2024731, which is invalid:

• expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aneeshkp]

/bugzilla refresh

[openshift-ci]

@aneeshkp: This pull request references Bugzilla bug 2024731, which is invalid:

• expected the bug to target the "4.10.0" release, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aneeshkp]

/bugzilla refresh

[openshift-ci]

@aneeshkp: An error was encountered querying GitHub for users with public email (omarzian@redhat.com) for bug 2024731 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.

non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aneeshkp]

/bugzilla refresh.

[SchSeba]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, SchSeba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [SchSeba]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

[openshift-ci]

@openshift-bot: This pull request references Bugzilla bug 2024731, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.10.0) matches configured target release for branch (4.10.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @marzianor9

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: marzianor9.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@openshift-bot: This pull request references Bugzilla bug 2024731, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.10.0) matches configured target release for branch (4.10.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @marzianor9

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@aneeshkp: Some pull requests linked via external trackers have merged:

• openshift/linuxptp-daemon#62

The following pull requests linked via external trackers have not merged:

• openshift/ptp-operator#158 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2024731 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 2024731:Remove ethtool status check loop

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aneeshkp]

/cherry-pick release-4.9

[openshift-cherrypick-robot]

@aneeshkp: #62 failed to apply on top of branch "release-4.9":

Applying: remove ethtool status check loop
Using index info to reconstruct a base tree...
M	pkg/daemon/ptpdev.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/daemon/ptpdev.go
CONFLICT (content): Merge conflict in pkg/daemon/ptpdev.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 remove ethtool status check loop
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aneeshkp]

/cherry-pick release-4.9.z

[openshift-cherrypick-robot]

@aneeshkp: cannot checkout release-4.9.z: error checking out release-4.9.z: exit status 1. output: error: pathspec 'release-4.9.z' did not match any file(s) known to git

Details

In response to this:

/cherry-pick release-4.9.z

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aneeshkp]

/cherry-pick release-4.9.z

[openshift-cherrypick-robot]

@aneeshkp: cannot checkout release-4.9.z: error checking out release-4.9.z: exit status 1. output: error: pathspec 'release-4.9.z' did not match any file(s) known to git

Details

In response to this:

/cherry-pick release-4.9.z

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aneeshkp]

/cherry-pick release-4.9

[openshift-cherrypick-robot]

@aneeshkp: new pull request created: #71

Details

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.