wip: Add e2e test that checks PreferredLinkTarget is updated

[jsafrane]

See the last commit only, the rest is #592

Update LocalVolume + LocalVolumeSets with a check for PreferredLinkTarget update.

The check picks one PV / LVDL, on the corresponding node it adds a new symlink to the corresponding device that's more preferred than the current one, and expects that the LVDL gets updated. Then it removes the symlink + checks the old PreferredLinkTarget is restored.

The test expects the test disks are NVMe. It creates a symlink scsi-1, which is more preferable by LSO. It can be extended in the future to add scsi-3, wwn- etc to check which one is actually the preferred one.

I also added some common functionality to add / remove udev-like symlinks on nodes easily and updated newNodeJob to get hostname instead of the whole Node object - it saves one API call to get a Node from hostname label from PV nodeAffinity.

WIP:

• remove 30 minute timeout that's there just for debugging
• perhaps refactor the check to a single function. Now it's copied to LV and LVSet unit tests.
• fix LocalVolumes - the test fails, because LSO does not update PreferredLinkTarget for LVs that are not mounted.

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

• do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f5c2f408-be95-40cb-ade0-f22e6cb3244f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-operator	21a862d	link	true	/test e2e-operator
ci/prow/verify	21a862d	link	true	/test verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.