OCPBUGS-76993: feat(node-deletion): remove stale LVMVolumeGroup finalizers

[qJkee]

remove LVMVolumeGroup node finalizer when node is being deleted

[openshift-ci-robot]

@qJkee: This pull request references Jira Issue OCPBUGS-76993, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

remove LVMVolumeGroup node finalizer when node is being deleted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qJkee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [qJkee]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-commenter]

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.39%. Comparing base (dc4e41c) to head (99e6ad9).
⚠️ Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/controllers/node/removal/controller.go	75.00%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2073      +/-   ##
==========================================
+ Coverage   49.16%   49.39%   +0.22%     
==========================================
  Files          52       52              
  Lines        3777     3778       +1     
==========================================
+ Hits         1857     1866       +9     
+ Misses       1767     1759       -8     
  Partials      153      153              

Files with missing lines	Coverage Δ
internal/controllers/node/removal/controller.go	81.15% <75.00%> (+12.04%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[openshift-ci]

@qJkee: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[suleymanakbas91]

/lgtm

[suleymanakbas91]

/jira refresh

[openshift-ci-robot]

@suleymanakbas91: This pull request references Jira Issue OCPBUGS-76993, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mmakwana30

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@qJkee: Jira Issue OCPBUGS-76993: All pull requests linked via external trackers have merged:

• openshift/lvm-operator#2073

Jira Issue OCPBUGS-76993 has been moved to the MODIFIED state.

Details

In response to this:

remove LVMVolumeGroup node finalizer when node is being deleted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[qJkee]

/cherry-pick release-4.21

[openshift-cherrypick-robot]

@qJkee: new pull request created: #2075

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.