Update e2e runner script #1080
Update e2e runner script #1080
Conversation
Add possibility to specify release branch for clone mapi e2e test suite. In case of openshift ci, PR target branch will be using as e2e release branch, which is more correct behaviour.
| OPENSHIFT_CI=${OPENSHIFT_CI:-""} | ||
| E2E_RELEASE_BRANCH=${E2E_RELEASE_BRANCH:-""} |
There was a problem hiding this comment.
Nit, I think the following has the same result
| OPENSHIFT_CI=${OPENSHIFT_CI:-""} | |
| E2E_RELEASE_BRANCH=${E2E_RELEASE_BRANCH:-""} | |
| OPENSHIFT_CI=${OPENSHIFT_CI:-} | |
| E2E_RELEASE_BRANCH=${E2E_RELEASE_BRANCH:-} |
There was a problem hiding this comment.
I would prefer to leave it as is, to be honest. Feels more explicit to me and we have the same pattern in other places.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
lobziik
changed the title
openshift-ci-robot
added
jira/severity-important
|
@lobziik: This pull request references Jira Issue OCPBUGS-2798, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold This does work differently as I thought Only vsphere-operator job is broken now. Hold till it would be discussed with the team |
openshift-ci
bot
added
the
do-not-merge/hold
|
I figured out that only vsphere jobs uses |
lobziik
changed the title
|
I think it still might be useful to merge, despite that original problem was solved another way. removing bug from this. It can wait till branch will open. /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/jira refresh |
|
@lobziik: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
/close |
|
@lobziik: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
Add possibility to specify release branch for clone mapi e2e test suite.
In case of openshift ci, PR target branch will be using as e2e release branch, which is more correct behaviour.
This need to be backported, will create a bug after initial review.