Skip to content

Conversation

@elmiko
Copy link
Contributor

@elmiko elmiko commented Jan 31, 2024

This file is only used for bringing in test dependencies it is not used in the final build release artifacts.

This file is only used for bringing in test dependencies it is not used
in the final build release artifacts.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 31, 2024
@openshift-ci-robot
Copy link
Contributor

@elmiko: This pull request references Jira Issue OCPBUGS-26119, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This file is only used for bringing in test dependencies it is not used in the final build release artifacts.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from elmiko. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@racheljpg
Copy link
Contributor

Hello! Mike and I have been looking at running snyk tests manually - this seems like a reasonable change to me, but unfortunately, after testing this change manually, snyk seems to still be trying to scan this file. Not sure if there's something we are missing in the formatting?

@elmiko
Copy link
Contributor Author

elmiko commented Jan 31, 2024

we found the underlying issue, basically snyk is running the go tooling to determine the dependencies and this tools.go file is throwing it off. since we don't use this file in our release builds, we have added build tags to the tools file so that it will not be included in the go commands that snyk is running. this happens before snyk excludes files which is why we aren't seeing snyk exclude it.

@elmiko elmiko closed this Jan 31, 2024
@openshift-ci-robot
Copy link
Contributor

@elmiko: This pull request references Jira Issue OCPBUGS-26119. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

This file is only used for bringing in test dependencies it is not used in the final build release artifacts.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@elmiko elmiko deleted the snyk-ignore-tools-file branch January 31, 2024 16:45
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2024

@elmiko: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-upgrade e276b94 link false /test e2e-vsphere-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants