Skip to content

Conversation

@jianlinliu
Copy link

@jianlinliu jianlinliu commented Nov 26, 2025

Reverts #1430 ; tracked by TRT-2440

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This PR broke 4.21.0-0.nightly-2025-11-26-014720

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2

CC: @jhixson74

PR created by Revertomatic™️

…_throughput"

This reverts commit 798f605, reversing
changes made to 1d78f2e.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 26, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 26, 2025

@jianlinliu: This pull request references TRT-2440 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

In response to this:

Reverts #1430 ; tracked by TRT-2440

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This PR broke 4.21.0-0.nightly-2025-11-26-014720

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2

CC: @jhixson74

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 26, 2025

@jianlinliu: This pull request references TRT-2440 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

In response to this:

Reverts #1430 ; tracked by TRT-2440

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

This PR broke 4.21.0-0.nightly-2025-11-26-014720

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2

CC: @jhixson74

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jianlinliu
Copy link
Author

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2

@openshift-ci openshift-ci bot requested review from chrischdi and nrb November 26, 2025 09:22
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 26, 2025

@jianlinliu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/68303940-caa9-11f0-8539-a45b689a2d6f-0

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign racheljpg for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JoelSpeed
Copy link
Contributor

/hold

This is not the problematic PR. You can see in the configuration for the machinesets that something has explicitly set the value 0 for this field. The code here is correct, whatever is explicitly setting a 0 value is incorrect.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2025
@JoelSpeed
Copy link
Contributor

@jianlinliu The issue is in openshift/installer#9945

@jianlinliu
Copy link
Author

@jianlinliu The issue is in openshift/installer#9945

Yeah, noticed that and comment there - openshift/installer#9945 (comment). The final fix should correct the default value.

@jianlinliu
Copy link
Author

/close

@openshift-ci openshift-ci bot closed this Nov 26, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 26, 2025

@jianlinliu: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants