Skip to content

OCPBUGS-78795: [release-4.18] : correct aws kms permissions#1478

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.18from
openshift-cherrypick-robot:cherry-pick-1371-to-release-4.18
Mar 20, 2026
Merged

OCPBUGS-78795: [release-4.18] : correct aws kms permissions#1478
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.18from
openshift-cherrypick-robot:cherry-pick-1371-to-release-4.18

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #1371

/assign patrickdillon

@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug OCPBUGS-56227 on the Jira server at https://redhat.atlassian.net. No known errors were detected, please see the full error message for details.

Full error message. request failed. Please analyze the request body for more details. Status code: 400: {"errorMessages":[],"errors":{"rankBeforeIssue":"expected Object","rankAfterIssue":"expected Object"}}

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.
/retitle [release-4.18] : correct aws kms permissions

Details

In response to this:

This is an automated cherry-pick of #1371

/assign patrickdillon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d2ca7b37-d1a5-4e4f-87d3-23d3455d5775

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot changed the title [release-4.18] OCPBUGS-56227: correct aws kms permissions [release-4.18] : correct aws kms permissions Mar 16, 2026
@openshift-ci openshift-ci bot requested review from damdo and elmiko March 16, 2026 15:29
@patrickdillon
Copy link
Contributor

@mtulio @Phaow @JoelSpeed @yunjiang29 This support for encrypted AMIs was requested back to 4.18, but the backports stopped at 4.19

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@damdo
Copy link
Member

damdo commented Mar 16, 2026

/label backport-risk-assessed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Mar 16, 2026
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2026
@damdo
Copy link
Member

damdo commented Mar 17, 2026

@patrickdillon we'll need a bug chain for this

@patrickdillon
Copy link
Contributor

patrickdillon commented Mar 18, 2026

/jira cherrypick OCPBUGS-56159

1 similar comment
@patrickdillon
Copy link
Contributor

/jira cherrypick OCPBUGS-56159

@openshift-ci-robot
Copy link
Contributor

@patrickdillon: Jira Issue OCPBUGS-56159 has been cloned as Jira Issue OCPBUGS-78795. Will retitle bug to link to clone.
/retitle OCPBUGS-78795: [release-4.18] : correct aws kms permissions

Details

In response to this:

/jira cherrypick OCPBUGS-56159

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.18] : correct aws kms permissions OCPBUGS-78795: [release-4.18] : correct aws kms permissions Mar 18, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 18, 2026
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-78795, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-56159 to target a version in 4.19.0, 4.19.z, but it targets "4.20.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1371

/assign patrickdillon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@patrickdillon
Copy link
Contributor

/jira cc-qa

@yunjiang29 We need to get this backported to 4.18. The installer permission fixes are lower priority.

@Phaow
Copy link
Contributor

Phaow commented Mar 19, 2026

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@Phaow: This pull request references Jira Issue OCPBUGS-78795, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Phaow
Copy link
Contributor

Phaow commented Mar 19, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 19, 2026
@openshift-ci-robot
Copy link
Contributor

@Phaow: This pull request references Jira Issue OCPBUGS-78795, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-56227 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-56227 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0, 4.19.z
  • bug has dependents

Requesting review from QA contact:
/cc @yunjiang29

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yunjiang29 March 19, 2026 01:04
@yunjiang29
Copy link

/verified by @yunjiang29

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 20, 2026
@openshift-ci-robot
Copy link
Contributor

@yunjiang29: This PR has been marked as verified by @yunjiang29.

Details

In response to this:

/verified by @yunjiang29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2026

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b3a96a4 into openshift:release-4.18 Mar 20, 2026
11 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-78795
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-78795 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #1371

/assign patrickdillon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants