[release-4.17] Use resource group when generating default Azure image#1481
[release-4.17] Use resource group when generating default Azure image#1481patrickdillon wants to merge 3 commits intoopenshift:release-4.17from
Conversation
Test that if a custom resource group is set, the default image uses that in the resource id.
Prior to this, the default always assumed the resource group was in the form infraID-rg, but that is not the case for users installing into existing resource groups. Instead, read it off the infrastructure config.
The resource group is required on the infrastructure resource, so it should be safe to always read it. To be completely defensive we can assume the default resource group in the impossible case that resource group is not specified.
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
damdo
left a comment
damdo
left a comment
There was a problem hiding this comment.
/approve
/lgtm
/label backport-risk-assessed
openshift-ci
bot
added
the
backport-risk-assessed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@patrickdillon: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
pre-merge tested with this PR on 4.17, ran the scenarios described here, all passed. /verified by jima |
openshift-ci-robot
added
the
verified
|
@jinyunma: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
7 participants
Manual backport of #1475