OCPCLOUD-3438: Bump govmomi to 0.53.0

[dlom]

Hive depends on two other projects with a govmomi dependency: The installer and the MAO. We're in the process of revendoring the installer, and they have pulled in a newer version of govmomi that is slightly backwards incompatible. The actual "change" is a one-line fix in pkg/controller/vsphere/reconciler.go

xref: OCPCLOUD-3438

/cc @suhanime
/cc @2uasimojo

Motivator: openshift/hive#2901

Summary by CodeRabbit

• Chores

  • Updated dependencies to latest stable versions.

• Bug Fixes

  • Corrected CPU core configuration handling during virtual machine cloning operations.

[openshift-ci-robot]

@dlom: This pull request references OCPCLOUD-3438 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Hive depends on two other projects with a govmomi dependency: The installer and the MAO. We're in the process of revendoring the installer, and they have pulled in a newer version of govmomi that is slightly backwards incompatible. The actual "change" is a one-line fix in pkg/controller/vsphere/reconciler.go

xref: OCPCLOUD-3438

/cc @suhanime
/cc @2uasimojo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6be81114-03bc-4233-8349-5f620618c0b6

📥 Commits

Reviewing files that changed from the base of the PR and between 3687798 and 2f70df9.

⛔ Files ignored due to path filters (85)

• go.sum is excluded by !**/*.sum
• vendor/github.com/vmware/govmomi/crypto/keylocator.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/crypto/url_helpers.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/fault/meta_types.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/internal/version/version.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/list/lister.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/object/datastore.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/object/folder.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/object/host_system.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/object/virtual_device_list.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/ovf/cim.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/ovf/configspec.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/simulator/container_virtual_machine.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/simulator/environment_browser.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/simulator/esx/host_config_info.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/simulator/esx/host_hardware_info.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/simulator/esx/host_system.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/simulator/esx/virtual_device.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/simulator/fault_injection.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/simulator/folder.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/simulator/host_datastore_browser.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/simulator/host_datastore_system.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/simulator/ovf_manager.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/simulator/registry.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/simulator/session_manager.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/simulator/simulator.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/simulator/snapshot.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/simulator/virtual_disk_manager.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/simulator/virtual_machine.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/simulator/vstorage_object_manager.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/vapi/internal/internal.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/vapi/library/library.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/vapi/library/library_configuration.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/vapi/library/library_usage.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/vapi/rest/client.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/vapi/rest/errors.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/vapi/rest/notifications.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/vapi/simulator/simulator.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/vim25/client.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/vim25/methods/methods.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/vim25/methods/unreleased.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/vim25/mo/extra.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/vim25/mo/registry.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/vim25/types/enum.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/vim25/types/guest.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/vim25/types/hardware_version.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/vim25/types/helpers.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/vim25/types/types.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/vim25/types/unreleased.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/vmdk/descriptor.go is excluded by !**/vendor/**, !vendor/**
• vendor/github.com/vmware/govmomi/vmdk/writer.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/cases/tables10.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/cases/tables11.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/cases/tables12.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/cases/tables15.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/cases/tables17.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/cases/tables9.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/message/catalog/catalog.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/message/catalog/dict.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/message/catalog/go19.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/message/catalog/gopre19.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/secure/bidirule/bidirule.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/secure/bidirule/bidirule10.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/secure/bidirule/bidirule9.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/unicode/bidi/tables10.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/unicode/bidi/tables11.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/unicode/bidi/tables12.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/unicode/bidi/tables13.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/unicode/bidi/tables15.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/unicode/bidi/tables17.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/unicode/bidi/tables9.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/unicode/norm/forminfo.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/unicode/norm/tables10.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/unicode/norm/tables11.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/unicode/norm/tables12.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/unicode/norm/tables15.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/unicode/norm/tables17.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/unicode/norm/tables9.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/width/tables10.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/width/tables11.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/width/tables12.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/width/tables15.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/width/tables17.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/golang.org/x/text/width/tables9.0.0.go is excluded by !**/vendor/**, !vendor/**
• vendor/modules.txt is excluded by !**/vendor/**, !vendor/**

📒 Files selected for processing (2)

• go.mod
• pkg/controller/vsphere/reconciler.go

---

Walkthrough

Dependencies are updated: vmware/govmomi upgraded from v0.52.0 to v0.53.0 and golang.org/x/text bumped from v0.33.0 to v0.34.0. The reconciler's VM clone specification adapts to the govmomi API change by assigning NumCoresPerSocket as a pointer instead of a direct value.

Changes

Dependency Update & Code Adaptation

Layer / File(s)	Summary
Dependency Bumps go.mod	vmware/govmomi upgraded to v0.53.0; golang.org/x/text upgraded to v0.34.0 (indirect).
API Adaptation pkg/controller/vsphere/reconciler.go	VM clone specification's NumCoresPerSocket field now assigned as a pointer (&numCoresPerSocket) to match the updated govmomi API signature.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 10 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Single Node Openshift (Sno) Test Compatibility	⚠️ Warning	New Ginkgo e2e tests assume multi-node/HA clusters with multiple failure domains and machine scaling, without SNO compatibility guards.	Add [Skipped:SingleReplicaTopology] labels to test cases in test/e2e/vsphere/multi-nic.go, test/e2e/vsphere/machines.go, and test/e2e/vsphere/hostzonal.go that assume multiple nodes and failure domains.

✅ Passed checks (10 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change in the changeset - bumping govmomi from v0.52.0 to v0.53.0, which is the primary modification in go.mod.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR does not modify any test files. Changes are limited to go.mod (dependencies) and pkg/controller/vsphere/reconciler.go (non-test code). Custom check is not applicable.
Test Structure And Quality	✅ Passed	This PR doesn't add/modify Ginkgo tests. The test files use standard Go testing framework with table-driven patterns, not Ginkgo. The check is not applicable to this PR's scope.
Microshift Test Compatibility	✅ Passed	All 24 new Ginkgo e2e tests have [apigroup:machine.openshift.io] tags. MicroShift CI auto-skips tests with apigroup tags for unavailable APIs, providing proper protection.
Topology-Aware Scheduling Compatibility	✅ Passed	PR bumps govmomi v0.52→0.53 and golang.org/x/text, and fixes a type signature in reconciler.go. No scheduling constraints, pod affinity rules, or deployment manifests were modified.
Ote Binary Stdout Contract	✅ Passed	No stdout violations. OTE binary uses logs.InitLogs() which redirects to stderr. No fmt.Print calls found. Reconciler change is data structure only (pointer assignment).
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests added. PR only modifies go.mod and reconciler.go. Check not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.1)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign radekmanak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[2uasimojo]

/retest

Looks like some test infra glitchiness.

[openshift-ci]

@dlom: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6	2f70df9	link	true	/test e2e-metal-ipi-ovn-ipv6
ci/prow/regression-clusterinfra-aws-ipi-mapi	2f70df9	link	false	/test regression-clusterinfra-aws-ipi-mapi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.