Skip to content

Ensure the Baremetal CRD is installed before metal3 is deployed #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2019
Merged

Ensure the Baremetal CRD is installed before metal3 is deployed #398

merged 1 commit into from
Oct 11, 2019

Conversation

@sadasu
Copy link
Contributor

@sadasu sadasu commented Sep 16, 2019 •
edited
Loading

Moving installation of Baremetal CRD before Metal3 deployment happens.
Also, adding the baremetal CRD to kustomization.yaml to keep it up-to-date.
Fixes issue #397.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 16, 2019
enxebre
enxebre reviewed Sep 16, 2019
View reviewed changes
@sadasu sadasu mentioned this pull request Sep 16, 2019
Closed
@sadasu sadasu force-pushed the baremetal-crd branch 2 times, most recently from a9372a5 to 59eed14 Compare September 20, 2019 14:24
@sadasu
Copy link
Contributor Author

sadasu commented Sep 23, 2019

/test e2e-aws-operator

@sadasu
Copy link
Contributor Author

sadasu commented Sep 25, 2019

/retest

@sadasu
Copy link
Contributor Author

sadasu commented Sep 26, 2019

/test e2e-aws-scaleup-rhel7

@sadasu
Copy link
Contributor Author

sadasu commented Oct 4, 2019

/test e2e-aws-operator

1 similar comment
@sadasu
Copy link
Contributor Author

sadasu commented Oct 8, 2019

/test e2e-aws-operator

@sadasu
Copy link
Contributor Author

sadasu commented Oct 9, 2019

/test e2e-aws

@sadasu
Copy link
Contributor Author

sadasu commented Oct 9, 2019

/test e2e-aws-upgrade

@sadasu
Copy link
Contributor Author

sadasu commented Oct 10, 2019

/test e2e-aws-operator

@sadasu
Ensure the Baremetal CRD is installed
6015625 
Moving install of the baremetal CRD to before 0000_30_machine-api-operator_11_deployment.yaml so that it is available at the time of Metal3 deployment.
Fixes issue openshift#397.
@sadasu
Copy link
Contributor Author

sadasu commented Oct 10, 2019

/test e2e-aws-upgrade

@sadasu
Copy link
Contributor Author

sadasu commented Oct 10, 2019

/test e2e-aws-scaleup-rhel7

@sadasu sadasu requested a review from enxebre October 10, 2019 20:00
@sadasu
Copy link
Contributor Author

sadasu commented Oct 10, 2019

@bison @ingvagabund can you please provide your reviews?

@enxebre
Copy link
Member

enxebre commented Oct 11, 2019 •
edited
Loading

can you please update the description and the commit message? the kustomization.yaml file is just a helper for devs atm, the rest of the content in the description does not applies to this PR

@sadasu sadasu changed the title Ensure the Baremetal CRD is installed Ensure the Baremetal CRD is installed before metal3 is deployed Oct 11, 2019
@enxebre
Copy link
Member

enxebre commented Oct 11, 2019

@sadasu ignore my comment above, I haven't notice the install/ file move
/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2019
@enxebre
Copy link
Member

enxebre commented Oct 11, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2019
@sadasu
Copy link
Contributor Author

sadasu commented Oct 11, 2019

@michaelgugino would you be able to review this?

@michaelgugino
Copy link
Contributor

michaelgugino commented Oct 11, 2019

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, michaelgugino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [enxebre,michaelgugino]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7e28692 into openshift:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bison bison Awaiting requested review from bison

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@enxebre enxebre

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sadasu @enxebre @michaelgugino @openshift-ci-robot @ingvagabund @openshift-merge-robot