bug 1765427: Add index for getting machines from node. #436
Conversation
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@enxebre: This pull request references Bugzilla bug 1765427, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/L
pkg/controller/machinehealthcheck/machinehealthcheck_controller.go
Outdated
Show resolved
Hide resolved
| // newReconciler returns a new reconcile.Reconciler | ||
| func newReconciler(mgr manager.Manager, opts manager.Options) *ReconcileMachineHealthCheck { | ||
| func newReconciler(mgr manager.Manager, opts manager.Options) (*ReconcileMachineHealthCheck, error) { | ||
| if err := mgr.GetCache().IndexField(&mapiv1.Machine{}, |
There was a problem hiding this comment.
Don't matter really, so not a blocker, but I feel like this might belong in Add() or add() instead of here.
|
@enxebre: This pull request references Bugzilla bug 1765427, which is valid. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/test e2e-aws |
1 similar comment
|
/test e2e-aws |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bison The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/test e2e-aws-upgrade |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@enxebre: All pull requests linked via external trackers have merged. Bugzilla bug 1765427 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
This allows to find a backing machine for a node not found, therefore letting remediation to take place when reconciliation is triggered by a node deletion.