Skip to content

Conversation

runcom
Copy link
Member

@runcom runcom commented Aug 6, 2019

Signed-off-by: Antonio Murdaca runcom@linux.com

- What I did

Updated kubernetes and kubelet vendors to use openshift forks. Not yet sure if we have a tracker for this yet, will update accordingly.

cc @mrunalp @sjenning @derekwaynecarr

- How to verify it

- Description for the changelog

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 6, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2019
@runcom
Copy link
Member Author

runcom commented Aug 6, 2019

LB limits...

@runcom
Copy link
Member Author

runcom commented Aug 6, 2019

/hold

got word that we need all other k8s.io/* moved to openshift forks

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 6, 2019
Signed-off-by: Antonio Murdaca <runcom@linux.com>
@runcom runcom force-pushed the update-kube-kubelet branch from 796bb1b to 310e9cc Compare August 7, 2019 10:48
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 7, 2019
@runcom
Copy link
Member Author

runcom commented Aug 7, 2019

/hold cancel

updated all others k8s.io/* deps to use the openshift's forks, good to go

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2019
@runcom
Copy link
Member Author

runcom commented Aug 7, 2019

/retest

@sjenning
Copy link
Contributor

sjenning commented Aug 7, 2019

/lgtm
thanks 👍

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: runcom, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b6d6fde into openshift:master Aug 7, 2019
@runcom runcom deleted the update-kube-kubelet branch August 7, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants