Skip to content

Conversation

@cheesesashimi
Copy link
Member

@cheesesashimi cheesesashimi commented Feb 7, 2024

This is a potential remedy for something uncovered in #4158. I only opened this PR in order to test this particular change in isolation and will close this PR once I know whether this change has any unintended consequences on our e2e test suites.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2024
@cheesesashimi
Copy link
Member Author

/test e2e-gcp-op
/test e2e-gcp-op-layering
/test e2e-gcp-op-sno

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2024
@cheesesashimi
Copy link
Member Author

/test e2e-gcp-op-single-node

@cheesesashimi
Copy link
Member Author

/test unit

@cheesesashimi
Copy link
Member Author

/test e2e-gcp-op

@cheesesashimi
Copy link
Member Author

This change did not cause any unintended side effects. Closing PR.

@cheesesashimi
Copy link
Member Author

/test e2e-aws-ovn-fips-op

I'm running this as a baseline to establish whether TestFirstBootHasSSHKeys passes in a FIPS context.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

@cheesesashimi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-fips-op d5dba19 link false /test e2e-aws-ovn-fips-op

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cheesesashimi cheesesashimi deleted the zzlotnik/e2e-helper-change branch March 21, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant