docs/Update-SSHKeys: fix SSH key example#509
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Feb 28, 2019
Merged
docs/Update-SSHKeys: fix SSH key example#509openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
The previous version had the SSH keys listed as `- ssh rsa AAAA...`, so I thought the MCO was doing some sort of magic parsing. Turns out it needed the commonly seen representation of `- ssh-rsah AAAAA...` I added a few examples showing how you can provide different key types and cleaned up some trailing whitespace.
openshift-ci-robot
added
the
size/S
Contributor
|
thanks for this!! /lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, miabbott The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
Contributor
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous version had the SSH keys listed as
- ssh rsa AAAA..., so Ithought the MCO was doing some sort of magic parsing. Turns out it
needed the commonly seen representation of
- ssh-rsa AAAAA...I added a few examples showing how you can provide different key types
and cleaned up some trailing whitespace.