MCO-1924: MCO-500: Migrate direct runGetOut() to use CommandRunner in the MCD

[isabella-janssen]

- What I did

• Remove the legacy runGetOut function https://github.com/isabella-janssen/machine-config-operator/blob/e52120b2cded908564878b30f7e87efa4709dcd6/pkg/daemon/command_runner.go#L38-L44 and its references in favor of the RunGetOut function that makes use of the CommandRunnerOS struct https://github.com/isabella-janssen/machine-config-operator/blob/e52120b2cded908564878b30f7e87efa4709dcd6/pkg/daemon/command_runner.go#L21-L36
• Make a new CreatePodmanContainer function to make use of the PodmanExecInterface struct
• Update & create relevant tests
• General code cleanup

- How to verify it
This is just code refactoring and cleanup, so existing functionality should remain unchanged.

- Description for the changelog
MCO-1924: Migrate direct runGetOut() to use CommandRunner in the MCD

[isabella-janssen]

/test all

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[isabella-janssen]

/test all

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1924 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1924 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

- What I did

• Remove the legacy runGetOut function https://github.com/isabella-janssen/machine-config-operator/blob/e52120b2cded908564878b30f7e87efa4709dcd6/pkg/daemon/command_runner.go#L38-L44 and its references in favor of the RunGetOut function that makes use of the CommandRunnerOS struct https://github.com/isabella-janssen/machine-config-operator/blob/e52120b2cded908564878b30f7e87efa4709dcd6/pkg/daemon/command_runner.go#L21-L36
• Make a new CreatePodmanContainer function to make use of the PodmanExecInterface struct
• Update & create relevant tests
• General code cleanup

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[umohnani8]

/lgtm

Great cleanup!

[pablintino]

/lgtm
Agree with the @umohnani8 's LGTM. Thanks for the clean up.

[pablintino]

/retest-required

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1924 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

- What I did

• Remove the legacy runGetOut function https://github.com/isabella-janssen/machine-config-operator/blob/e52120b2cded908564878b30f7e87efa4709dcd6/pkg/daemon/command_runner.go#L38-L44 and its references in favor of the RunGetOut function that makes use of the CommandRunnerOS struct https://github.com/isabella-janssen/machine-config-operator/blob/e52120b2cded908564878b30f7e87efa4709dcd6/pkg/daemon/command_runner.go#L21-L36
• Make a new CreatePodmanContainer function to make use of the PodmanExecInterface struct
• Update & create relevant tests
• General code cleanup

- How to verify it
This is just code refactoring and cleanup, so existing functionality should remain unchanged.

- Description for the changelog
MCO-1924: Migrate direct runGetOut() to use CommandRunner in the MCD

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1924 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

- What I did

• Remove the legacy runGetOut function https://github.com/isabella-janssen/machine-config-operator/blob/e52120b2cded908564878b30f7e87efa4709dcd6/pkg/daemon/command_runner.go#L38-L44 and its references in favor of the RunGetOut function that makes use of the CommandRunnerOS struct https://github.com/isabella-janssen/machine-config-operator/blob/e52120b2cded908564878b30f7e87efa4709dcd6/pkg/daemon/command_runner.go#L21-L36
• Make a new CreatePodmanContainer function to make use of the PodmanExecInterface struct
• Update & create relevant tests
• General code cleanup

- How to verify it
This is just code refactoring and cleanup, so existing functionality should remain unchanged.

- Description for the changelog
MCO-1924: Migrate direct runGetOut() to use CommandRunner in the MCD

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[isabella-janssen]

/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview 1of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-2of2 periodic-ci-openshift-release-master-ci-4.22-e2e-aws-ovn-techpreview-serial-1of3 periodic-ci-openshift-release-master-ci-4.22-e2e-aws-ovn-techpreview-serial-2of3 periodic-ci-openshift-release-master-ci-4.22-e2e-aws-ovn-techpreview-serial-3of3

[openshift-ci]

@isabella-janssen: trigger 5 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview
• periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-2of2
• periodic-ci-openshift-release-master-ci-4.22-e2e-aws-ovn-techpreview-serial-1of3
• periodic-ci-openshift-release-master-ci-4.22-e2e-aws-ovn-techpreview-serial-2of3
• periodic-ci-openshift-release-master-ci-4.22-e2e-aws-ovn-techpreview-serial-3of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8973d210-fe16-11f0-9a09-c8c7f17d6d20-0

[umohnani8]

/lgtm
/verified bypass

[openshift-ci-robot]

@umohnani8: The verified label has been added.

Details

In response to this:

/lgtm
/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen, pablintino, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [isabella-janssen,pablintino,umohnani8]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d464ec8 and 2 for PR HEAD a9ea655 in total

[isabella-janssen]

/retitle MCO-1924: MCO-500: Migrate direct runGetOut() to use CommandRunner in the MCD

[pablintino]

/retest-required

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD c9188a4 and 1 for PR HEAD a9ea655 in total

[openshift-ci]

@isabella-janssen: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.