[release-4.15] OCPBUGS-23418: Machine-config controller should not log about non-existent pull-secret changes

[dkhater-redhat]

- What I did
Fixed false-positive log spam where MCC logged "Re-syncing ControllerConfig due to secret pull-secret change" every ~25 minutes even though the pull-secret secret hadn't actually changed.

- How to verify it
Check logs on a running cluster

1. Install a cluster with this fix
2. Wait 1+ hours without modifying the pull-secret
3. Check MCC logs:
   oc logs -n openshift-machine-config-operator -l k8s-app=machine-config-controller -c machine-config-controller --tail=-1 | grep -c 'Re-syncing ControllerConfig due to secret pull-secret change'
4. Expected: Count should be 0 (no false positives)
5. Without fix: Count would be ~7+ over a few hours

- Description for the changelog

[openshift-ci-robot]

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-23418, which is invalid:

• expected the bug to target the "4.15.z" version, but no target version was set
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-23418 to depend on a bug targeting a version in 4.16.0, 4.16.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

- What I did
Fixed false-positive log spam where MCC logged "Re-syncing ControllerConfig due to secret pull-secret change" every ~25 minutes even though the pull-secret secret hadn't actually changed.

- How to verify it
Check logs on a running cluster

1. Install a cluster with this fix
2. Wait 1+ hours without modifying the pull-secret
3. Check MCC logs:
   oc logs -n openshift-machine-config-operator -l k8s-app=machine-config-controller -c machine-config-controller --tail=-1 | grep -c 'Re-syncing ControllerConfig due to secret pull-secret change'
4. Expected: Count should be 0 (no false positives)
5. Without fix: Count would be ~7+ over a few hours

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkhater-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dkhater-redhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@dkhater-redhat: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-gcp-op	7f0cfaa	link	false	/test okd-scos-e2e-gcp-op
ci/prow/e2e-hypershift	7f0cfaa	link	true	/test e2e-hypershift
ci/prow/okd-scos-e2e-aws-ovn	7f0cfaa	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/okd-scos-e2e-gcp-ovn-upgrade	7f0cfaa	link	false	/test okd-scos-e2e-gcp-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.